Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,shikra-pas: Document Shikra PAS remoteprocs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The dt-binding example incorrectly mixes SMD RPM components with RPMh power domain constants.
--

commit 69848c4ac32e863c52c6df41cb4da6b7c711fe47
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,shikra-pas: Document Shikra PAS remoteprocs

This commit documents the device tree bindings for the CDSP, LPAICP, and
MPSS Peripheral Authentication Service (PAS) on the Qualcomm Shikra SoC.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> new file mode 100644
> index 0000000000000..f0b9e04d84620
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> @@ -0,0 +1,157 @@
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmcc.h>
> +    #include <dt-bindings/interconnect/qcom,icc.h>
> +    #include <dt-bindings/interconnect/qcom,rpm-icc.h>
> +    #include <dt-bindings/interconnect/qcom,shikra.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/qcom-rpmpd.h>
> +
> +    remoteproc@b300000 {
> +        compatible = "qcom,shikra-cdsp-pas";
> +        reg = <0x0b300000 0x100000>;
[ ... ]
> +        clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
> +        clock-names = "xo";
> +
> +        interconnects = <&mem_noc MASTER_AMPSS_M0 RPM_ALWAYS_TAG
> +                         &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>;
> +
> +        power-domains = <&rpmpd RPMHPD_CX>;

[Severity: Low]
Is this using the correct power domain constant for the Shikra SoC?

The example appears to mix SMD RPM components with RPMh power domain constants.
It uses an SMD RPM clock (RPM_SMD_XO_CLK_SRC) and the rpmpd phandle, but
assigns RPMHPD_CX to the power domain, which is an RPMh constant.

Since Shikra is an SMD RPM SoC, should this use an SMD RPM constant like
RPMPD_VDDCX instead to prevent semantic inaccuracies and potential copy-paste
errors in actual device trees?

> +        power-domain-names = "cx";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520-shikra-rproc-v2-0-583a2e413a3a@oss.qualcomm.com?part=1