Re: [PATCH] dt-bindings: misc: add YAML binding for qemu,pvpanic-mmio

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The commit introduces a YAML version of the qemu,pvpanic-mmio binding without deleting the original text binding.
- [Low] The example uses a 4-cell `reg` property without specifying `#address-cells` and `#size-cells`, which will cause `dt_binding_check` to fail.
- [Low] Missing newline at the end of the YAML file.
--

commit 8822d211de2348fd88169fd34a07c2dd995de355
Author: Rohan Mithari <rohanmithari09@gmail.com>

dt-bindings: misc: add YAML binding for qemu,pvpanic-mmio

This commit adds a new YAML device tree binding schema for the QEMU PVPANIC
MMIO device.

> diff --git a/Documentation/devicetree/bindings/misc/qemu,pvpanic-mmio.yaml b/Documentation/devicetree/bindings/misc/qemu,pvpanic-mmio.yaml
> new file mode 100644
> index 0000000000000..22d1333f9c2df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/qemu,pvpanic-mmio.yaml

[Severity: Medium]
Does this patch omit the deletion of the original pvpanic-mmio.txt file?

When converting an older text device tree binding to the YAML format, the
original text file should typically be removed in the same commit to prevent
duplicated documentation and out-of-sync updates.

[ ... ]

> +examples:
> +  - |
> +    pvpanic@9060000 {
> +      compatible = "qemu,pvpanic-mmio";
> +      reg = <0x0 0x9060000 0x0 0x2>;

[Severity: Low]
Will this example trigger a schema validation error during make
dt_binding_check? 

In the dt-schema testing framework, example snippets are implicitly wrapped in
a root node where the default address-cells and size-cells are 1. The reg
property here provides 4 cells, which parses as an array of 2 distinct items.
However, the schema restricts the reg property with a maxItems: 1 constraint.

Could the example be updated to specify the correct address-cells and
size-cells to match the 4-cell reg property?

> +    };
> \ No newline at end of file

[Severity: Low]
This isn't a bug, but there is a missing trailing newline character at the
end of the file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520164846.637522-1-rohanmithari09@gmail.com?part=1