Re: [PATCH v5 6/7] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#thermal-sensor-cells` property is not marked as required for the new `airoha,an7583-chip-scu` variant, allowing incomplete device tree nodes to silently pass schema validation.
--

commit 87c7f9a301f3391f2461e89c9c85f755bb4ba049
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC

Document support for the Airoha AN7583 chip-scu node. This variant is
similar to the EN7581 but adds a thermal sensor capability in addition
to controlling HW PIN and other peripherals.

> diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> --- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml

[ ... ]

>  required:
>    - compatible
>    - reg
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: airoha,en7581-chip-scu
> +
> +then:
> +  properties:
> +    '#thermal-sensor-cells': false
> +

[Severity: Medium]
Should #thermal-sensor-cells be explicitly added to the required list for
the airoha,an7583-chip-scu variant?

When a hardware variant adds a new provider capability, the corresponding
standard properties typically need to be explicitly required. Without it,
incomplete device tree nodes missing the thermal sensor cells property might
silently pass schema validation.

Could an else block be added here to enforce this requirement?

else:
  required:
    - '#thermal-sensor-cells'

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520155525.22239-1-ansuelsmth@gmail.com?part=6