From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0C223F54C2; Thu, 21 May 2026 20:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779394094; cv=none; b=SQu4j0m8ZBfIa9ohjk5lMMeBkP81rLoOJyJKriairIsKyVckIy6Y44tJxvcYfV+9SegDhSiUwCzWHQdUBRgqElzqzOUWMDKcyrHaqdW0DntyVf25yBYnhzny3qWtnyvOz8XH0zgiO3brvWFDLi/hW1u+HgeDvIBR48+E4rsaWsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779394094; c=relaxed/simple; bh=707jK27ZELdllgXoMxuZs9+Kj+Za41Z+d79jxmYPrkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ts8CCFp/Qy9WTuXqrtDWT6Lgm2K/H/o5+X3WG9xxuGzEiBz4LJG4j7ocHQrVNkoAx0/FM/W/dHxmo+a3eb6dllOoBFyGrDUMoz8tOmfZy0uVKoA03jErPnOyFpdarOLqN0ONZQLBELXqxX529V7OvQF4F2v/vdaeb/CcfmR2pro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XnQhC89x; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XnQhC89x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A1E01F000E9; Thu, 21 May 2026 20:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779394092; bh=707jK27ZELdllgXoMxuZs9+Kj+Za41Z+d79jxmYPrkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XnQhC89x81h+yCkodScj88ddByjv2tXNQ9ox5EpkfYEkbUqs6gFJeqYItZinvYTvY nGOei2abuhB6Yz/cursfuF2ME+VN5H4K7gQJN1Ryot1KMbKKg+tfwgeUkoQtfdps6Z A+P60g/kPyvcov6QxzohAuStjaHKdz+bDuukmJ6yL5pBZsmgJdPRlhjBIZ2UzIxIT7 a4Gm1egxLXUBTJbqwcyZPK60MTOhifSBlpPf5qDoY06uuzTYWxprsFwCj4OuIItsN+ wn5p5pqW0A2yQuIXw7PM0vY6X0xFH5ttinTitzWsZsw+JDxM8/Eh6URlmHtnNdKdto bGbABwQtCXzXw== Date: Thu, 21 May 2026 21:08:07 +0100 From: Conor Dooley To: Chris Morgan Cc: Jonathan Cameron , Chris Morgan , linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com, Krzysztof Kozlowski Subject: Re: [PATCH V8 02/10] dt-bindings: iio: imu: icm42600: Add icm42607 binding Message-ID: <20260521-challenge-flaccid-26b6f5d2d0bd@spud> References: <20260518200526.458421-1-macroalpha82@gmail.com> <20260518200526.458421-3-macroalpha82@gmail.com> <20260520174217.6ca98524@jic23-huawei> <20260521-premium-afterlife-0d7a22b77517@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wintQjHsEd+E3xkx" Content-Disposition: inline In-Reply-To: --wintQjHsEd+E3xkx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 21, 2026 at 12:43:09PM -0500, Chris Morgan wrote: > On Thu, May 21, 2026 at 05:44:21PM +0100, Conor Dooley wrote: > > On Wed, May 20, 2026 at 05:42:17PM +0100, Jonathan Cameron wrote: > > > On Mon, 18 May 2026 15:05:17 -0500 > > > Chris Morgan wrote: > > >=20 > > > > From: Chris Morgan > > > >=20 > > > > Add devicetree binding for the Invensense ICM42607 and Invensense > > > > ICM42607P inertial measurement unit. This unit is a combined > > > > accelerometer, gyroscope, and thermometer available via I2C or SPI. > > > >=20 > > > > This device is functionally very similar to the icm42600 series wit= h a > > > > very different register layout. > > > >=20 > > > > Signed-off-by: Chris Morgan > > > > Acked-by: Krzysztof Kozlowski > > > Note that Sashiko has highlighted that the binding this being added to > > > has a potential problem. > > >=20 > > > interrupts are required but interrupt-names are not. > > > That would be fine but the binding doesn't say there is a default > > > ordering for the interrupts - so if we don't have names we have no > > > idea which interrupt it is. > > >=20 > > > This needs fixing - probably by adding a default > >=20 > > Worth pointing out that this isn't an issue with this particular patch, > > the problem exists in mainline. >=20 > The driver I lovingly borrowed this code from seems to have fallback > logic, basically picking the first interrupt if it couldn't find one > named "INT1". I was told early on not to do this that way, so in my > case the interrupt-names would be required (but not for the existing > driver because of this fallback). >=20 > Should I make the requirement conditional just to my compatible > strings? Sure, sounds like a good idea to me. --wintQjHsEd+E3xkx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCag9mJwAKCRB4tDGHoIJi 0uWgAP96xINoifZYfEqvlm8mnXkLoTpcNpRpexPVhkPesyjNSgEAyT1KnP4I+z5d not7x1APCxb9+VXz2wgU/dZA0O48bAo= =yomg -----END PGP SIGNATURE----- --wintQjHsEd+E3xkx--