Re: [PATCH v3] dt-bindings: iommu: riscv: Add bindings for Tenstorrent RISC-V IOMMU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `reg-names` property is missing `minItems: 1`, implicitly requiring exactly 2 items and breaking single-region nodes that attempt to use `reg-names`.
--

commit 4e6445ae92ce6111a15e470ab7f01dc3081a9f0b
Author: Nicholas Piggin <npiggin@gmail.com>

dt-bindings: iommu: riscv: Add bindings for Tenstorrent RISC-V IOMMU

This commit extends the riscv,iommu binding to support the Tenstorrent
RISC-V IOMMU. It adds a second register range for M-privileged registers
like PMAs and PMPs.

> diff --git a/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml b/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml
> index d4838c3b3741f..0ce9f7abd120b 100644
> --- a/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml

[ ... ]

> @@ -32,22 +32,34 @@ properties:

[ ... ]

> +  reg-names:
> +    items:
> +      - const: base
> +      - const: machine

[Severity: Medium]
Will this implicitly require exactly two items for reg-names?

In dt-schema, defining an array property with a list of items sets both
the minimum and maximum to the length of the list unless overridden.

If standard single-region IOMMUs attempt to provide a single reg-names
entry, will they fail schema validation because the schema expects exactly
two items?

Should minItems: 1 be added to the reg-names property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521064445.1740782-2-fustini@kernel.org?part=1