Re: [PATCH v4 1/2] dt-bindings: leds: backlight: document the SY7758 6-channel High Efficiency LED Driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing main power supply property (e.g., `vin-supply` or `vsys-supply`) for the LED boost converter.
--

commit f0b2513f96c13c59660da8495c808919bb4b44ab
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: leds: backlight: document the SY7758 6-channel High Efficiency LED Driver

Document the Silergy SY7758 6-channel High Efficiency LED Driver
used for backlight brightness control.

> diff --git a/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml b/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml
> new file mode 100644
> index 0000000000000..80e978d691c29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml

[ ... ]

> +properties:
> +  compatible:
> +    const: silergy,sy7758
> +
> +  reg:
> +    maxItems: 1
> +
> +  vddio-supply: true

[Severity: Low]
Should there be a vin-supply or vsys-supply property included here for the
main power input?

Looking at the driver implementation, it references VBST (V-Boost) registers,
confirming it operates as a boost converter to drive multiple LED channels.
A logic I/O supply like vddio-supply typically cannot provide the high
current required to drive a boost coil for a backlight.

Omitting the primary power supply could prevent the kernel from actively
managing the main power rail on boards where it is switchable.

> +
> +  enable-gpios:
> +    maxItems: 1
> +
> +required:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-topic-sm8650-ayaneo-pocket-s2-sy7758-v4-0-73c732615e4a@linaro.org?part=1