From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED02F31A07B for ; Thu, 21 May 2026 08:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779351752; cv=none; b=fdQpSuqz+jHJa6Dm9nfsURFn47fyL3y7iGAGtGxBv7WnaM7Nf7vnQkVHS62alf992Smj1YD9w+8pbBrn1DX501cY7TCzsnEgxZ7hqAJdafNJ8lH0vIJeCWXrrrHrBI+8VzZQBzQAfaxxPL4cS4KxgHxxzQemHqoasYzHpDlBFPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779351752; c=relaxed/simple; bh=gWLO77tZ9MbajFEgPVEjQUCT6ZTSoktNSTsYB3WGDKU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=h8YorwGtl3jHqJJJK943v/P4o1jAthY+tLREsYDLBn30ci0wPAoSZ7+J4FzbYEHscbMWsepoNMP4TEcEH40wu1v38ZOUIfGLDiK6+cLFcRDc812kPSlYGX7uavRGo9Tk0aFOY13bMFCX4cRZHNK8wuu299iqrDt7F/s31dVr7s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mQEZJpRY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mQEZJpRY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD161F000E9; Thu, 21 May 2026 08:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779351750; bh=qv3TtZ0qONesORUEiWfS5ijOH+9Ehz6dBfj4D+Vm9RM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=mQEZJpRYBUHi7Up/9Cm41+0WtSqk+Fai0ElVHvajbn7wXFclzQW8tsnG+g0fWbvy5 XNoOQn7n/jDP5bAvIq/l773+hQ5Hn2F/xhH3LjoOHnOeEIfQXXSdsApnmyAPCLJz6I qnkusBaKBJpO25UqzZAEj4U60Qip4CHtDv8huPLPfRSEn0dm4elgO2oay/nRWf07F/ tjYTZqsS8FF6H1ZGhKqFxtNUb9kRo87SOAlFC4BxnrVK90A5ddeJabT8xhfziXJ6tl +wkxd2XHLp1R2FP/nDzrJU3nWl/hq9obre7ZC+6RzIZzaM8qy0/Sv7zrHF+BLEVdrP gEm4AVVC8gyGQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 1/2] dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels Reply-To: sashiko-reviews@lists.linux.dev To: "Neil Armstrong" Cc: robh@kernel.org, devicetree@vger.kernel.org, wsa+renesas@sang-engineering.com, conor+dt@kernel.org In-Reply-To: <20260521-topic-sm8650-ayaneo-pocket-s2-r63419-v5-1-dd5700299390@linaro.org> References: <20260521-topic-sm8650-ayaneo-pocket-s2-r63419-v5-1-dd5700299390@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 21 May 2026 08:22:30 +0000 Message-Id: <20260521082230.6BD161F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The schema incorrectly uses `additionalProperties: false` instead o= f `unevaluatedProperties: false` when inheriting from a common schema. -- commit 06ab207971a6f54327d9bb05b5e8355cbba81b0c Author: Neil Armstrong dt-bindings: display: panel: document the Renesas R63419 based dual-DSI vid= eo mode Display Panels This commit adds a new device tree binding document for the Renesas R63419 generic DDIC. The DDIC is used to control dual-DSI LCD panels, such as those found in Ayaneo gaming handheld devices. > diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r634= 19.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r63419.ya= ml > new file mode 100644 > index 0000000000000..adfdd2c300a35 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml [ ... ] > +allOf: > + - $ref: panel-common-dual.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - ayaneo,wt0600-2k > + - ayaneo,wt0630-2k > + - const: renesas,r63419 [ ... ] > + backlight: true > + reset-gpios: true > + rotation: true > + ports: true > + > +required: > + - compatible > + - reg [ ... ] > + - reset-gpios > + - ports > + > +additionalProperties: false [Severity: Low] Since this schema inherits from panel-common-dual.yaml in the allOf block above, should this be unevaluatedProperties: false instead? In JSON schema, additionalProperties: false only considers the properties explicitly listed in the local properties block. This means any standard panel properties (like width-mm, height-mm, or enable-gpios) not explicitly listed here will be incorrectly rejected during validation. Using unevaluatedProperties: false would allow properties defined in the inherited schemas. It would also eliminate the need to redundantly define properties like backlight or ports in the local properties block. > + > +examples: > + - | [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260521-topic-sm86= 50-ayaneo-pocket-s2-r63419-v5-0-dd5700299390@linaro.org?part=3D1