Re: [PATCH v2 1/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `unevaluatedProperties: false` on `port@1` and `endpoint` nodes leads to leaky schema validation.
--

commit 707c36bedcf3fbf40724e79e4e941f57ce9d5a3a
Author: Damon Ding <damon.ding@rock-chips.com>

dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

This commit adds data-lanes property support to the port@1 endpoint for
physical lane mapping configuration to handle PCB lane swaps and mismatched
pin definitions.

> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
[ ... ]
>        port@1:
> -        $ref: /schemas/graph.yaml#/properties/port
> -        description:
> -          Port node with one endpoint connected to a dp-connector node.
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        description: Port node with one endpoint connected to sink device node.
> +        properties:
> +          endpoint:
> +            $ref: /schemas/media/video-interfaces.yaml#
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +                items:
> +                  enum: [ 0, 1, 2, 3 ]

[Severity: Medium]
Does this change allow undocumented properties or typos to silently pass
schema validation?

By replacing /schemas/graph.yaml#/properties/port with the open
/schemas/graph.yaml#/$defs/port-base, custom properties can be added.
However, since unevaluatedProperties: false is missing on both the port@1
and endpoint nodes, the schema validation becomes leaky.

Would it be better to add unevaluatedProperties: false to these nodes so
that property typos (like data-lane = <1 2 3 4>) are correctly flagged as
errors during dt_binding_check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521114459.1394264-1-damon.ding@rock-chips.com?part=1