Re: [PATCH v12 07/22] dt-bindings: media: i2c: max96712: add support for I2C ATR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `i2c-atr` node allows child nodes (`^i2c@[0-3]$`) with a `reg` property, but fails to make `#address-cells` and `#size-cells` required in the parent node.
- [Low] The `reg` property under the `i2c-atr`'s `^i2c@[0-3]$` child nodes applies invalid numeric constraints and lacks a `maxItems: 1` constraint.
--

commit 8c55c178a378c597e61e804da4b186def25c5a4c
Author: Cosmin Tanislav <demonsingur@gmail.com>

dt-bindings: media: i2c: max96712: add support for I2C ATR

This commit adds I2C ATR support for the MAX96712 and MAX96724 deserializers.
It documents the ability to change I2C addresses for connected serializers to
avoid conflicts when they share the same CFG pin configuration.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 583bbd60157c6..abacc3c874a9f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -36,6 +36,30 @@ properties:
>  
>    enable-gpios: true
>  
> +  i2c-alias-pool:
> +    maxItems: 4
> +
> +  i2c-atr:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +

[Severity: Low]
Since the i2c-atr node allows child nodes (^i2c@[0-3]$) with a reg property,
shouldn't #address-cells and #size-cells be explicitly listed in a required
block under i2c-atr?

Omitting them allows an incomplete device tree missing these parsing
properties to silently pass schema validation.

> +    patternProperties:
> +      '^i2c@[0-3]$':
> +        $ref: /schemas/i2c/i2c-controller.yaml#
> +        unevaluatedProperties: false
> +        properties:
> +          reg:
> +            items:
> +              minimum: 0
> +              maximum: 3

[Severity: Low]
Does this correctly constrain the reg property?

In dt-schema, the reg property is parsed as an array of arrays. Applying
items constraints to minimum and maximum attempts to enforce numeric limits on
the nested elements, which standard JSON Schema ignores for arrays, making it
a silent no-op.

Should this instead use maxItems: 1 to constrain the matrix length, while
relying on the unit-address regex pattern (^i2c@[0-3]$) to natively enforce
the bounds?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-gmsl2-3_serdes-v12-0-b26d92931196@analog.com?part=7