From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: imx@lists.linux.dev, conor+dt@kernel.org, Frank.Li@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/6] ARM: dts: imx: remove redundant bus-width for video-mux
Date: Thu, 21 May 2026 20:19:01 +0000 [thread overview]
Message-ID: <20260521201903.5448F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260521-imx25_dts_simple_warning_2-v2-2-c6557df516a9@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch removes the `bus-width` property from IPU CSI endpoints (e.g., `&ipu1_csi1_from_ipu1_csi1_mux`) without documenting this change in the commit message, which only mentions `video-mux` endpoints. Additionally, this removal leaves behind completely empty node overrides (e.g., `&ipu1_csi1_from_ipu1_csi1_mux {}`) which should be removed entirely to prevent unnecessary clutter.
--
commit 9fb698028cc05d2c61d201637e9e7246e95e81d5
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: imx: remove redundant bus-width for video-mux
This commit removes redundant bus-width properties from various i.MX device
tree files to resolve dtbs_check warnings. The bus-width is already
specified at the remote endpoint.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-gw52xx.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-gw52xx.dts
> index 9ea23dd54f3ce..62b05fe70cd97 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-gw52xx.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-gw52xx.dts
> @@ -32,12 +32,10 @@ adv7180_to_ipu1_csi1_mux: endpoint {
> };
>
> &ipu1_csi1_from_ipu1_csi1_mux {
> - bus-width = <8>;
> };
[Severity: Low]
This isn't a bug, but removing the bus-width property here leaves behind a
completely empty node override. Should these empty node overrides be removed
entirely to prevent unnecessary clutter?
Additionally, the commit message only mentions video-mux endpoints, but this
removes the property from IPU CSI endpoints as well. Could the commit message
be updated to reflect the full scope of the changes?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-imx25_dts_simple_warning_2-v2-0-c6557df516a9@nxp.com?part=2
next prev parent reply other threads:[~2026-05-21 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 19:15 [PATCH v2 0/6] ARM: dts: cleanup some CHECK_DTBS warning for imx5/6 (round 2) Frank.Li
2026-05-21 19:15 ` [PATCH v2 1/6] ARM: dts: imx: add (power|vdd)-supply for related node Frank.Li
2026-05-21 19:15 ` [PATCH v2 2/6] ARM: dts: imx: remove redundant bus-width for video-mux Frank.Li
2026-05-21 20:19 ` sashiko-bot [this message]
2026-05-21 19:15 ` [PATCH v2 3/6] ARM: dts: imx: Add bus-type for ov5642/ov5640 Frank.Li
2026-05-21 19:15 ` [PATCH v2 4/6] ARM: dts: imx6qdl-tx6: remove undocumented karo,imx6qdl-tx6-sgtl5000 and keep only simple-audio-card Frank.Li
2026-05-21 19:15 ` [PATCH v2 5/6] ARM: dts: imx: replace undocumented compatible string edt,edt-ft5x06 with edt,edt-ft5206 Frank.Li
2026-05-21 19:15 ` [PATCH v2 6/6] ARM: dts: imx6-display5: replace marvell,88E1510 with ethernet-phy-ieee802.3-c22 Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521201903.5448F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox