Re: [PATCH v14 2/6] mfd: add NXP MC33978/MC34978 core driver

[sashiko-bot@kernel.org]

> Add core Multi-Function Device (MFD) driver for the NXP MC33978 and
> MC34978 Multiple Switch Detection Interfaces (MSDI).
> 
> The MC33978/MC34978 devices provide 22 switch detection inputs, analog
> multiplexing (AMUX), and comprehensive hardware fault detection.
> 
> This core driver handles:
> - SPI communications via a custom regmap bus to support the device's
>   pipelined two-frame MISO response requirement.
> - Power sequencing for the VDDQ (logic) and VBATP (battery) regulators.
> - Interrupt demultiplexing, utilizing an irq_domain to provide 22 virtual
>   IRQs for switch state changes and 1 virtual IRQ for hardware faults.
> - Inline status harvesting from the SPI MSB to detect and trigger events
>   without requiring dedicated status register polling.
> 
> Child devices (pinctrl, hwmon, mux) are instantiated by the core driver
> from match data.
> 
> Note: The device currently lacks suspend/resume power management callbacks.
> If the system enters a sleep state cutting power to VDDQ/VBATP, the device
> will wake up in POR state with hardware interrupt masks reset. Power
> management support is intentionally deferred for now.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522044855.1772639-1-o.rempel@pengutronix.de?part=2