Re: [PATCH v2 02/10] arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The 'data-lanes' property is incorrectly placed directly within the main '&mdss0_dp3' node.
- [Low] The commit silently removes the `&dispcc1` node block without mentioning it in the commit message.
--

commit 5312e63401d73e35f694eed3e8a7dcb4db6c95e5
Author: Jérôme de Bretagne <jerome.debretagne@gmail.com>

arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display
    
This commit adds the necessary regulator, pinctrl, and display controller 
nodes to enable the eDP LCD display on the Surface Pro 9 5G.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> index f24f60dc73afe..476e17415da27 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
[ ... ]
> @@ -448,10 +463,6 @@ &dispcc0 {
>  	status = "okay";
>  };
>  
> -&dispcc1 {
> -	status = "okay";
> -};
> -

[Severity: Low]
This isn't a bug, but is it intentional to silently remove the &dispcc1
node here?

The commit message focuses on enabling the eDP display and does not mention
removing this block.

>  &gpi_dma0 {
>  	status = "okay";
[ ... ]
> @@ -494,6 +505,42 @@ &mdss0_dp1_out {
>  	remote-endpoint = <&usb_1_qmpphy_dp_in>;
>  };
>  
> +&mdss0_dp3 {
> +	compatible = "qcom,sc8280xp-edp";
> +	/delete-property/ #sound-dai-cells;
> +
> +	data-lanes = <0 1 2 3>;

[Severity: Low]
Should the data-lanes property be placed inside the controller's output
endpoint node (&mdss0_dp3_out) rather than here in the main &mdss0_dp3 node?

Placing data-lanes in the root controller node is deprecated in the
qcom,dp-controller Devicetree binding and will trigger dtbs_check
validation warnings.

> +
> +	status = "okay";
> +
> +	aux-bus {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-surface-sp9-5g-for-next-v2-0-dd9d477407f5@gmail.com?part=2