Re: [PATCH 4/5] arm64: dts: freescale: imx95-15x15-frdm: remove common rmem regions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete cleanup leaving orphaned remoteproc memory regions (`vdev1vring0` and `vdev1vring1`), causing a code and commit message mismatch.
--

commit c3d174a8ecea96cc404dfedae6ae093499f849dd
Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

arm64: dts: freescale: imx95-15x15-frdm: remove common rmem regions

This commit removes reserved memory regions used for remoteproc on the
MX95-15x15-FRDM platform, noting they are unused and can be included in an
RPMSG-specific DTS instead.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> index 0f43e3be70589..f9b0e266754d6 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts
> @@ -188,16 +188,6 @@ linux_cma: linux,cma {
>  			linux,cma-default;
>  		};
>  
> -		vdev0vring0: memory@88000000 {
> -			reg = <0 0x88000000 0 0x8000>;
> -			no-map;
> -		};
> -
> -		vdev0vring1: memory@88008000 {
> -			reg = <0 0x88008000 0 0x8000>;
> -			no-map;
> -		};
> -
>  		vdev1vring0: memory@88010000 {
>  			reg = <0 0x88010000 0 0x8000>;
>  			no-map;
> @@ -208,17 +198,6 @@ vdev1vring1: memory@88018000 {
>  			no-map;
>  		};

[Severity: Medium]
The commit message mentions removing the reserved memory regions used for
remoteproc. Should vdev1vring0 and vdev1vring1 also be removed here?

Since they retain the no-map property, do these remaining nodes unnecessarily
carve out memory without being referenced anymore?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522111849.783-1-laurentiumihalcea111@gmail.com?part=4