Re: [PATCH v6 1/2] dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect use of `additionalProperties: false` with a `$ref` to a common schema, causing validation failures for standard properties.
--

commit d5d9023fc9149b85c30a89eb9e658f1d3b246c85
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

This commit documents the Renesas R63419 generic display driver IC used to
control dual-DSI LCD panels. It introduces a new YAML binding schema for
devices such as the Ayaneo gaming handheld panels.

> diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml
> new file mode 100644
> index 0000000000000..adfdd2c300a35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml
[ ... ]
> +allOf:
> +  - $ref: panel-common-dual.yaml#
> +
> +properties:
> +  compatible:
[ ... ]
> +  vdd-supply: true
> +  vddio-supply: true
> +  vsp-supply: true
> +  vsn-supply: true
> +  vci-supply: true
> +
> +  backlight: true
> +  reset-gpios: true
> +  rotation: true
> +  ports: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +  - vddio-supply
> +  - vsp-supply
> +  - vsn-supply
> +  - vci-supply
> +  - backlight
> +  - reset-gpios
> +  - ports
> +
> +additionalProperties: false

[Severity: Low]
Should unevaluatedProperties: false be used here instead of
additionalProperties: false?

Because this schema includes a reference to panel-common-dual.yaml in an
allOf block, additionalProperties only considers the properties explicitly
declared in this local file. This requires redundantly redeclaring standard
properties like backlight, reset-gpios, rotation, and ports to prevent
validation errors during dtbs_check.

Using unevaluatedProperties: false would properly evaluate against the
referenced schemas and allow removing the redundant property declarations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-topic-sm8650-ayaneo-pocket-s2-r63419-v6-0-16edddda9951@linaro.org?part=1