Re: [PATCH v5 1/2] regulator: dt-bindings: document the SGM3804 Dual Output regulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `enable-gpios` property is incorrectly marked as strictly required and lacks a `maxItems: 1` constraint.
--

commit f50493aa554fa5cd96589605f9a49a0134ff39ab
Author: Neil Armstrong <neil.armstrong@linaro.org>

regulator: dt-bindings: document the SGM3804 Dual Output regulator

This commit documents the sgm3804 single inductor dual output buck/boost
converter. It provides bindings for the positive and negative power rails,
including configurable voltages and active discharge functions.

> diff --git a/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml b/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml
> new file mode 100644
> index 0000000000000..3716eaf81aa99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/sgmicro,sgm3804.yaml

[ ... ]

> +patternProperties:
> +  "^(pos|neg)$":
> +    type: object
> +    $ref: regulator.yaml#
> +
> +    properties:
> +      enable-gpios: true

[Severity: Medium]
Should enable-gpios have a maxItems constraint here? The core regulator.yaml
schema does not define a maxItems limit for enable-gpios, so setting this to
true allows an arbitrary number of gpios to be specified in the device tree
instead of a single enable pin per output.

> +
> +    unevaluatedProperties: false
> +
> +    required:
> +      - enable-gpios

[Severity: Medium]
Is it strictly necessary to require enable-gpios for these child nodes? If a
board design hardwires the hardware enable pins to an always-on supply to
conserve processor pins, the regulator would be constantly powered but still
configurable via i2c. Marking enable-gpios as strictly required will cause a
schema validation failure for those valid hardware configurations, even if
the driver currently expects the pins to be present.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-topic-sm8650-ayaneo-pocket-s2-sgm3804-v5-0-bd6b1c300ecc@linaro.org?part=1