Re: [PATCH v3 05/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect interrupt trigger edge configured for the active-low touch controller interrupt.
--

commit fab3f681a92c02497462fd11a6e8c83f2e40950e
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI

This commit adds a device tree overlay for the Toradex Capacitive Touch
Display 10.1" on the Verdin DSI_1 interface. It configures the SN65DSI83
bridge, Riverdi LCD panel, and Ilitek ILI2132 touch controller, while
providing combined DTBs in the Makefile.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-dsi
Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-display-adapter/

> diff --git a/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-10inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-10inch-dsi.dtso
> new file mode 100644
> index 0000000000000..ed66feec94624
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-10inch-dsi.dtso

[ ... ]

> +	touchscreen@41 {
> +		compatible = "ilitek,ili2132";
> +		reg = <0x41>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_dsi1_int>, <&pinctrl_i2s_2_bclk_gpio>;
> +		/* Verdin GPIO_9_DSI (SODIMM 17) - TOUCH_INT# */
> +		interrupt-parent = <&main_gpio1>;
> +		interrupts = <49 IRQ_TYPE_EDGE_RISING>;

[Severity: Medium]
The comment indicates the interrupt pin is TOUCH_INT#, which typically denotes
an active-low signal.

Is IRQ_TYPE_EDGE_RISING the correct trigger here?

Triggering on a rising edge for an active-low signal means the interrupt will
fire only upon de-assertion. If the touch controller holds the line low until
the event is read via I2C, waiting for a rising edge could delay or prevent
the touch input event from being processed. Should this be configured as
IRQ_TYPE_EDGE_FALLING instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522161105.277519-13-ivitro@gmail.com?part=5