Re: [PATCH v5 2/8] media: dt-bindings: add rockchip rk3588 vicap

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `minItems` constraint for `reset-names` in the RK3588 conditional block.
--

commit 63f5bfe4a138b18bc1581d3e98d7e6a10fe7ef3e
Author: Michael Riesch <michael.riesch@collabora.com>

media: dt-bindings: add rockchip rk3588 vicap

This commit adds documentation for the Rockchip RK3588 Video Capture (VICAP)
unit. It generalizes the existing rockchip,rk3568-vicap documentation and
introduces variant-specific constraints.

> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
> --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml
[ ... ]
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3588-vicap
> +    then:
> +      properties:
[ ... ]
> +        resets:
> +          minItems: 9
> +
> +        reset-names:
> +          items:
> +            - const: arst
> +            - const: hrst
> +            - const: drst
> +            - const: irst0
> +            - const: irst1
> +            - const: irst2
> +            - const: irst3
> +            - const: irst4
> +            - const: irst5

[Severity: Low]
Does this schema correctly enforce the length of the reset-names array for the
rk3588-vicap variant?

Since the global reset-names definition allows a minimum of 5 items, omitting
minItems: 9 here means a device tree could provide exactly 9 resets but only
5 reset-names and still pass validation. Should this include minItems: 9 to
match the resets property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-rk3588-vicap-v5-0-d1d1f5265c56@collabora.com?part=2