From: sashiko-bot@kernel.org
To: "Aleksander Jan Bajkowski" <olek2@wp.pl>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: mediatek: add LED and key support on Xiaomi AX3000T
Date: Sat, 23 May 2026 10:37:02 +0000 [thread overview]
Message-ID: <20260523103703.5A49F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260523101904.293215-1-olek2@wp.pl>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `key-mesh` node incorrectly pairs `linux,code = <BTN_9>` with `linux,input-type = <EV_SW>`. Since `BTN_9` (265) exceeds `SW_MAX`, the input subsystem rejects the capability, causing a kernel error splat on boot and rendering the button completely non-functional.
--
commit b3e6ab558b15225bf59d262cc68b446d232036a9
Author: Aleksander Jan Bajkowski <olek2@wp.pl>
arm64: dts: mediatek: add LED and key support on Xiaomi AX3000T
This commit adds device tree support for the physical buttons and
status LEDs present on the Xiaomi AX3000T router.
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
> index a314c3e05e500..db399cb3ead73 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-xiaomi-ax3000t.dts
[ ... ]
> @@ -12,4 +15,37 @@ memory@40000000 {
> reg = <0 0x40000000 0 0x10000000>;
> device_type = "memory";
> };
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + key-mesh {
> + label = "MESH";
> + gpios = <&pio 0 GPIO_ACTIVE_LOW>;
> + linux,code = <BTN_9>;
> + linux,input-type = <EV_SW>;
[Severity: Medium]
Will this combination of EV_SW and BTN_9 cause a capability rejection
during boot?
During the gpio-keys driver probe, input_set_capability() is called to
register the button capability. This function strictly bounds-checks the
event code against the maximum for the given type.
For EV_SW, input_max_code is SW_MAX (17). Since BTN_9 (265) exceeds SW_MAX,
the check fails, causing the kernel to print an error splat and return
early without registering the switch capability.
Does this leave the mesh button completely non-functional when pressed?
> + };
> +
> + key-reset {
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260523101904.293215-1-olek2@wp.pl?part=1
next prev parent reply other threads:[~2026-05-23 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 10:18 [PATCH RESEND] arm64: dts: mediatek: add LED and key support on Xiaomi AX3000T Aleksander Jan Bajkowski
2026-05-23 10:37 ` sashiko-bot [this message]
2026-05-25 8:43 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260523103703.5A49F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox