Re: [PATCH v3 04/17] dt-bindings: timer: arm,arch_timer: Fix requirements for interrupt description

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `minItems: 2` constraint in the `interrupts` array maps to the wrong interrupts due to the static `items` list, contradicting the commit message's stated requirements.
--

commit 5eb08d516ae8d3fb049e6d6f31c8f0dd7d3f7165
Author: Marc Zyngier <maz@kernel.org>

dt-bindings: timer: arm,arch_timer: Fix requirements for interrupt description

This commit updates the arm,arch_timer binding to explicitly define the
requirements for interrupts based on the architecture. It increases the
minimum number of interrupts from 1 to 2, clarifies architectural
terminology for the interrupts, and removes outdated descriptions.

> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
> index c5fc3b6c8bd0b..c65e48a155ab6 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml

[ ... ]

> @@ -33,13 +28,13 @@ properties:
>            - const: arm,armv7-timer
>  
>    interrupts:
> -    minItems: 1
> +    minItems: 2
>      items:
> -      - description: secure timer irq
> -      - description: non-secure timer irq
> -      - description: virtual timer irq
> -      - description: hypervisor timer irq
> -      - description: hypervisor virtual timer irq
> +      - description: EL1 secure physical timer irq, if EL3 is implemented
> +      - description: EL1 non-secure physical timer irq
> +      - description: EL1 virtual timer irq
> +      - description: EL2 physical timer irq, if EL2 is implemented
> +      - description: EL2 virtual timer irq, if FEAT_VHE is implemented

[Severity: Medium]
Does changing this to minItems: 2 while keeping a static items list cause
the first two provided interrupts to always be validated against the
"EL1 secure physical" and "EL1 non-secure physical" descriptions?

JSON schema array validation maps elements sequentially by index. If a
device tree node only provides 2 interrupts (the always-required EL1
non-secure physical and EL1 virtual timers), they will be mapped to the
first two indices.

Since the EL1 secure physical timer is optional (only if EL3 is
implemented), should interrupts use a oneOf block with separate lists,
mirroring the existing structure of interrupt-names, to correctly model
when the first element is omitted?

>  
>    interrupt-names:
>      oneOf:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260523140242.586031-1-maz@kernel.org?part=4