Re: [PATCH 2/2] devicetree: Mark QCE bindings as deprecated

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Improper deprecation of a Device Tree binding based on Linux driver usage, along with missing `deprecated: true` property.
--

commit b96bab0a35ba5a2a033dd44bb8dfef71eb077fa4
Author: Demi Marie Obenour <demiobenour@gmail.com>

devicetree: Mark QCE bindings as deprecated

This commit updates the description of the QCE crypto controller binding
to state that it is no longer used by the kernel and is kept only for
backwards compatibility.

> devicetree: Mark QCE bindings as deprecated
>
> They are no longer used by the kernel.  Keep them to avoid unnecessary
> churn and because I know next to nothing about devicetree.

[Severity: Medium]
Aren't device tree bindings intended to describe hardware independently of
OS or software drivers? Deprecating a hardware binding solely because the
Linux kernel driver was removed appears to violate the principle of
OS-agnostic hardware description.

> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index 08febd66c22ba..0f378073ddf55 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -14,6 +14,9 @@ description:
>    This document defines the binding for the QCE crypto
>    controller found on Qualcomm parts.
>  
> +  This driver is no longer used and so this binding only exists
> +  for backwards compatibility.
> +
>  properties:
>    compatible:
>      oneOf:

[Severity: Medium]
If this binding should legitimately be marked as deprecated, does it also
need the standard deprecated: true JSON schema property at the root level?

By only adding an informal note to the description, validation tools like
dtbs_check cannot parse this state and will fail to issue standard
deprecation warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260523-delete-qce-v1-0-86105cd7f406@gmail.com?part=2