Re: [PATCH RFC v2 1/7] dt-bindings: iio: add Open Sensor Fusion UART device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The binding lacks a reference to standard serial peripheral properties, restricting valid UART configurations.
- [Low] The new vendor prefix 'opensensorfusion' is inserted out of alphabetical order in vendor-prefixes.yaml.
- [Low] The device tree example uses a specific, non-generic node name ('osf').
--

commit d7438989beeea74dd5628fa3759c1cbb1ffb5900
Author: Jinseob Kim <kimjinseob88@gmail.com>

dt-bindings: iio: add Open Sensor Fusion UART device

This commit adds a device tree binding for the OSF0 UART-attached sensor
aggregation device. The device communicates capability, status, and sample
frames to the host via a serial connection.

> diff --git a/Documentation/devicetree/bindings/iio/imu/opensensorfusion,osf-uart.yaml b/Documentation/devicetree/bindings/iio/imu/opensensorfusion,osf-uart.yaml
> new file mode 100644
> index 0000000000000..d4a8f68192e9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/opensensorfusion,osf-uart.yaml
[ ... ]
> +required:
> +  - compatible
> +
> +additionalProperties: false

[Severity: Medium]
Since this is a UART-attached device, will board device trees need to specify
standard serial properties like current-speed? Without a $ref to
/schemas/serial/serial-peripheral-props.yaml and setting
unevaluatedProperties: false instead, setting standard UART properties will
cause schema validation to fail.

> +
> +examples:
> +  - |
> +    serial {
> +        osf {

[Severity: Low]
This isn't a bug, but does this follow the devicetree specification for generic
node names? Usually, node names should reflect the primary function of the
device, such as sensor or imu, rather than the specific product name.

> +            compatible = "opensensorfusion,osf-uart";
> +        };
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 28784d66ae7ba..121b83f7046ad 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1239,6 +1239,8 @@ patternProperties:
>      description: OpenRISC.io
>    "^openwrt,.*":
>      description: OpenWrt
> +  "^opensensorfusion,.*":
> +    description: Open Sensor Fusion project

[Severity: Low]
This isn't a bug, but is this vendor prefix inserted out of alphabetical
order? "opensensorfusion" should alphabetically come before "openwrt".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524085312.15369-1-kimjinseob88@gmail.com?part=1