Re: [PATCH] ASoC: dt-bindings: sound: asahi-kasei,ak5386: Convert DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema uses `additionalProperties: false` but omits a reference to `dai-common.yaml#` and the `#sound-dai-cells` property, which will cause validation failures for valid audio configurations.
- [Medium] The new schema breaks backward compatibility by rejecting the legacy `reset-gpio` property that was documented in the original text binding.
--

commit 53f12bd4c4466e68926d73a25cd532a103036343
Author: Manish Baing <manishbaing2789@gmail.com>

ASoC: dt-bindings: sound: asahi-kasei,ak5386: Convert DT schema

This commit converts the Asahi Kasei AK5386 ADC binding from the legacy
text format to the YAML schema format.

> diff --git a/Documentation/devicetree/bindings/sound/ak5386.txt b/Documentation/devicetree/bindings/sound/ak5386.txt
> deleted file mode 100644
> --- a/Documentation/devicetree/bindings/sound/ak5386.txt
> +++ /dev/null
[ ... ]
> -Optional properties:
> -
> -  - reset-gpio : a GPIO spec for the reset/power down pin.
> -		 If specified, it will be deasserted at probe time.
[ ... ]
> diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak5386.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak5386.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak5386.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: asahi-kasei,ak5386
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: A GPIO spec for the reset/power down pin.

[Severity: Medium]
Does this break backward compatibility with existing device trees?

The original text binding explicitly documented the reset pin as
reset-gpio (singular), and existing device trees may be using that
property.

Since the driver uses devm_gpiod_get_optional() which handles the legacy
-gpio suffix automatically, the driver still works, but the new schema
will reject it due to additionalProperties: false.

Should the legacy reset-gpio property be defined here, perhaps marked as
deprecated, to maintain DT ABI backwards compatibility?

> +
> +  va-supply:
> +    description: Power supply for the analog section.
> +
> +  vd-supply:
> +    description: Power supply for the digital section.
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false

[Severity: Medium]
Will this reject valid audio configurations?

The AK5386 functions as an audio codec and Digital Audio Interface (DAI)
provider. Standard ASoC generic sound cards require the codec node to have
the #sound-dai-cells property to resolve the codec phandle.

Because the schema enforces additionalProperties: false without defining
#sound-dai-cells or referencing dai-common.yaml#, it seems dtbs_check
will fail on valid device trees.

Should this include a reference to dai-common.yaml# and use
unevaluatedProperties: false instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524160158.109983-1-manishbaing2789@gmail.com?part=1