Re: [PATCH] ARM: dts: imx7d-pico-pi: add OV5645 camera support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect `clock-frequency` assignment in the `&mipi_csi` node drastically reduces the MIPI CSI wrapper clock, causing image capture failures.
--

commit aa98f4a3e7fa5b72ccc19a9fd456c518fe7ea6ff
Author: Lech Perczak <lech.perczak@gmail.com>

ARM: dts: imx7d-pico-pi: add OV5645 camera support

This commit adds the OV5645 camera device node and enables the relevant
components in the video capture data path for the imx7d-pico-pi. The
author noted that the camera probes successfully but image transfer fails,
suspecting pixel format incompatibilities.

Link: https://github.com/technexion-android/kernel_imx/blob/ce8fd74abf518dac0a09e8dcb37f3496f6375124/arch/arm/boot/dts/imx7d-pico.dtsi#L874 [1]

> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-pico-pi.dts b/arch/arm/boot/dts/nxp/imx/imx7d-pico-pi.dts
> index 62221131336f1..b36936ecfa4ba 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7d-pico-pi.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-pico-pi.dts
[ ... ]
> @@ -93,5 +120,38 @@ MX7D_PAD_EPDC_DATA04__GPIO2_IO4		0x14
[ ... ]
> +&mipi_csi {
> +	status = "okay";
> +	clock-frequency = <24000000>;

[Severity: Medium]
Could this clock-frequency assignment be the cause of the image capture
failures mentioned in the commit message?

According to the nxp,imx-mipi-csi2.yaml binding schema and the
imx-mipi-csis.c driver, this deprecated property overrides the MIPI CSI-2
receiver's internal wrap clock.

By forcing this clock to 24 MHz, it drastically underclocks the peripheral
from its default of 166 MHz. This renders it too slow to process incoming
high-speed MIPI CSI-2 data. 

Removing this property should allow the peripheral to use its proper
high-speed default clock.

> +
> +	ports {
> +		port@0 {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524175312.10952-1-lech.perczak@gmail.com?part=1