Re: [PATCH v2] ASoC: dt-bindings: sound: atmel_ac97c: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML schema conversion incorrectly modifies the list of required properties compared to the original text binding by omitting `ac97-gpios` and adding `clocks` and `clock-names` without justification.
--

commit 78a24354563be69b55ed4c3cb505afc48e0f2156
Author: Manish Baing <manishbaing2789@gmail.com>

ASoC: dt-bindings: sound: atmel_ac97c: Convert to DT schema
    
Convert the Atmel AC97 controller binding from text format to YAML schema.

> diff --git a/Documentation/devicetree/bindings/sound/atmel,at91sam9263-ac97c.yaml b/Documentation/devicetree/bindings/sound/atmel,at91sam9263-ac97c.yaml
> new file mode 100644
> index 0000000000000..5f4ebe81bf907
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/atmel,at91sam9263-ac97c.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names

[Severity: Medium]
Are clocks and clock-names strictly required now, and is the omission of
ac97-gpios intentional?

The original text binding listed ac97-gpios under the required properties
section, but did not document clocks or clock-names as required. Altering
binding constraints during a text-to-YAML conversion without explaining the
changes in the commit message can cause dtbs_check to fail for existing
device trees or weaken validation.

Could the commit message be updated to explain these constraint changes, or
should the required list be adjusted to match the original text binding?

> diff --git a/Documentation/devicetree/bindings/sound/atmel_ac97c.txt b/Documentation/devicetree/bindings/sound/atmel_ac97c.txt
> deleted file mode 100644
> index b151bd902ce3d..0000000000000
> --- a/Documentation/devicetree/bindings/sound/atmel_ac97c.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -* Atmel AC97 controller
> -
> -Required properties:
> -  - compatible: "atmel,at91sam9263-ac97c"
> -  - reg: Address and length of the register set for the device
> -  - interrupts: Should contain AC97 interrupt
> -  - ac97-gpios: Please refer to soc-ac97link.txt, only ac97-reset is used

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524195318.112398-1-manishbaing2789@gmail.com?part=1