Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series
Date: Sun, 24 May 2026 22:11:26 +0000	[thread overview]
Message-ID: <20260524221126.CA3471F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260524-veml6031x00-v3-1-29165609b2b5@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new entry in the MAINTAINERS file breaks alphabetical sorting.
--

commit c75afbde2cfc8b7f8986709a43e0d1e7b6d9ebe5
Author: Javier Carrasco <javier.carrasco.cruz@gmail.com>

dt-bindings: iio: light: veml6030: add veml6031x00 ALS series

This commit updates the veml6030 bindings to include the veml6031x00 ambient
light sensor series. It adds the new compatible strings and creates a new
entry in the MAINTAINERS file for the driver.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fb1c75afd163..94a23bac568d3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -28381,6 +28381,11 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml
>  F:	drivers/iio/light/veml6046x00.c
>  
> +VISHAY VEML6031X00 AMBIENT LIGHT SENSOR DRIVER

[Severity: Low]
This isn't a bug, but does this insertion break the alphabetical sorting of
the MAINTAINERS file? 

Since "VEML6031" comes before "VEML6046", should this new block be placed
above the VISHAY VEML6046X00 entry to maintain the standard lexicographical
ordering?

> +M:	Javier Carrasco <javier.carrasco.cruz@gmail.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
> +
>  VISHAY VEML6075 UVA AND UVB LIGHT SENSOR DRIVER

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524-veml6031x00-v3-0-29165609b2b5@gmail.com?part=1

  reply	other threads:[~2026-05-24 22:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 21:53 [PATCH v3 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-05-24 21:53 ` [PATCH v3 1/4] dt-bindings: iio: light: veml6030: add " Javier Carrasco
2026-05-24 22:11   ` sashiko-bot [this message]
2026-05-24 21:53 ` [PATCH v3 2/4] iio: light: add support for " Javier Carrasco
2026-05-24 22:53   ` sashiko-bot
2026-05-25  0:29     ` Javier Carrasco
2026-05-24 21:53 ` [PATCH v3 3/4] iio: light: veml6031x00: add support for triggered buffers Javier Carrasco
2026-05-24 23:29   ` sashiko-bot
2026-05-24 21:53 ` [PATCH v3 4/4] iio: light: veml6031x00: add support for events and trigger Javier Carrasco
2026-05-25  0:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260524221126.CA3471F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox