From: Conor Dooley <conor@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
robh@kernel.org, wsa+renesas@sang-engineering.com,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
Date: Mon, 25 May 2026 17:37:31 +0100 [thread overview]
Message-ID: <20260525-myth-flanking-667fa0a706ac@spud> (raw)
In-Reply-To: <20260523194047.AB7CA1F00A3A@smtp.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]
On Sat, May 23, 2026 at 07:40:47PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Adding 18 items to `clock-output-names` in the example triggers a `dt_binding_check` schema validation error due to an un-updated top-level constraint in `renesas,cpg-clocks.yaml`.
> --
>
> commit aaa0ff6ae07f5974071a547fef4a5b41bc484428
> Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
>
> dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example
>
> This commit updates the R-Mobile APE6 clock node example to include
> the "zt" and "ztr" clock-output-names entries. This aligns the example
> with the expectations documented in a previous commit.
>
> > diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > index 2197c952e21df..b6ee8c8efd46d 100644
> > --- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
> > @@ -60,7 +60,7 @@ examples:
> > clock-output-names = "main", "pll0", "pll1", "pll2",
> > "pll2s", "pll2h", "z", "z2",
> > "i", "m3", "b", "m1", "m2",
> > - "zx", "zs", "hp";
> > + "zx", "zs", "hp", "ztr", "zt";
>
> [Severity: Low]
> Does adding these two items cause a schema validation failure during
> dt_binding_check?
>
> The top-level clock-output-names property in renesas,cpg-clocks.yaml has a
> maxItems constraint of 17. Adding "ztr" and "zt" here brings the total
> item count to 18.
>
> While the underlying limit omission occurred in the earlier commit
> 2abdc3dcf978, modifying this example to 18 items will now directly
> trigger the overarching validation limit error.
What does renesas,cpg-clocks.yaml have to do with this?
This is just complete crap, right?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-05-25 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:25 [PATCH] dt-bindings: clock: renesas: div6: Use ZT/ZTR trace clock in R-Mobile APE6 example Marek Vasut
2026-05-23 19:40 ` sashiko-bot
2026-05-25 16:37 ` Conor Dooley [this message]
2026-05-25 19:45 ` Marek Vasut
2026-05-25 19:47 ` Conor Dooley
2026-06-24 13:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525-myth-flanking-667fa0a706ac@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox