Re: [PATCH v8 1/2] media: dt-bindings: Add CSI Pixel Formatter DT bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The dt-binding example will fail `dt_binding_check` due to an invalid `reg` property length and unit address mismatch in the parent `syscon` node.
- [Low] Misleading indentation of the closing braces for the `endpoint` node within `port@0` in the dt-binding example.
--

commit 6a7b1f87ea2dd192a60ffaf87f2da35cb030c9a0
Author: Guoniu Zhou <guoniu.zhou@nxp.com>

media: dt-bindings: Add CSI Pixel Formatter DT bindings

This commit adds the device tree bindings for the i.MX95 CSI pixel
formatting module. The module reformats packet info and data from the
CSI-2 host controller to match the Pixel Link definition.

> diff --git a/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml
> new file mode 100644
> index 0000000000000..bc2f5d448fe58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/clock/nxp,imx95-clock.h>
> +
> +    syscon@4ac10000 {
> +        compatible = "nxp,imx95-camera-csr", "syscon";
> +        reg = <0x0 0x4ac10000 0x0 0x10000>;

[Severity: Low]
Will this example successfully pass dt_binding_check?

The syscon node uses a 4-cell reg property, which requires a parent node
configured with #address-cells = <2> and #size-cells = <2>. Since this node
is placed at the root of the example, the implicit root node defaults to 1
for both cells, which can trigger a dtc warning due to an invalid property
length.

> +        #address-cells = <1>;
> +        #size-cells = <1>;
[ ... ]
> +                port@0 {
> +                    reg = <0>;
> +
> +                    endpoint {
> +                        remote-endpoint = <&mipi_csi_0_out>;
> +                };
> +            };

[Severity: Low]
This isn't a bug, but the closing braces for the endpoint and port@0 nodes
have misleading indentation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-csi_formatter-v8-0-6b646231224b@oss.nxp.com?part=1