From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@flipper.net>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: nau8822: Add supply regulators
Date: Mon, 25 May 2026 09:29:31 +0000 [thread overview]
Message-ID: <20260525092932.711941F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260525-nau8822-reg-v2-1-7d37ae393e46@flipper.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the description for `vddspk-supply`.
--
commit 2a0698dd10cf90a92b31e252ae2cfd2a236cf2d9
Author: Alexey Charkov <alchark@flipper.net>
ASoC: dt-bindings: nau8822: Add supply regulators
This commit adds optional power supply pins (VDDA, VDDB, VDDC, and VDDSPK)
to the NAU8822 device tree binding. This allows device tree users to ensure
correct power sequencing before communicating with the device.
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> index cb8182bbc491f..cf4c130382411 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
[ ... ]
> @@ -30,6 +30,20 @@ properties:
> clock-names:
> const: mclk
>
> + vdda-supply:
> + description: Analog power supply
> +
> + vddb-supply:
> + description: Digital buffer (input/output) supply
> +
> + vddc-supply:
> + description: Digital core supply
> +
> + vddspk-supply:
> + description:
> + Speaker supply (power supply pin for RSPKOUT, LSPKOUT, AUXOUT2 and
> + AUXTOUT1 output drivers)
[Severity: Low]
This isn't a bug, but there appears to be a typo here. Should this be
AUXOUT1 instead of AUXTOUT1 to match the actual pin and driver definition?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-nau8822-reg-v2-0-7d37ae393e46@flipper.net?part=1
next prev parent reply other threads:[~2026-05-25 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 9:20 [PATCH v2 0/2] ASoC: nau8822: add support for supply regulators Alexey Charkov
2026-05-25 9:20 ` [PATCH v2 1/2] ASoC: dt-bindings: nau8822: Add " Alexey Charkov
2026-05-25 9:29 ` sashiko-bot [this message]
2026-05-25 9:53 ` Alexey Charkov
2026-05-25 9:20 ` [PATCH v2 2/2] ASoC: codecs: nau8822: add support for " Alexey Charkov
2026-05-25 9:51 ` sashiko-bot
2026-05-25 10:29 ` Alexey Charkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525092932.711941F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alchark@flipper.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox