Re: [PATCH v13 1/6] dt-bindings: iio: adc: add AD4691 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding introduces GPIO controller capabilities (`gpio-controller` and `#gpio-cells`) but fails to include them in the `required` list and omits them from the `examples` section.
--

commit 77c288f18d0b66cc82083af2dbedfa800cf9c577
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: adc: add AD4691 family

Add DT bindings for the Analog Devices AD4691 family of multichannel
SAR ADCs (AD4691, AD4692, AD4693, AD4694).

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> new file mode 100644
> index 0000000000000..af28a0c1cfa9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml

[ ... ]

> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  '#trigger-source-cells':
> +    description:
> +      This node can act as a trigger source. The single cell in a consumer
> +      reference specifies the GP pin number (0-3) used as the trigger output.
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - vio-supply

[Severity: Medium]
Since this binding introduces GPIO controller capabilities, should
gpio-controller and #gpio-cells be added to this required list?

Without these properties in the required list, incomplete device tree nodes
missing the GPIO provider capabilities can pass schema validation.

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    /* AD4692 in CNV Burst Mode with SPI offload */
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "adi,ad4692";
> +            reg = <0>;
> +            spi-cpol;
> +            spi-cpha;
> +            spi-max-frequency = <40000000>;
> +
> +            avdd-supply = <&avdd_supply>;
> +            ldo-in-supply = <&avdd_supply>;
> +            vio-supply = <&vio_supply>;
> +            ref-supply = <&ref_5v>;
> +
> +            reset-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
> +
> +            pwms = <&pwm_gen 0 0>;
> +
> +            #trigger-source-cells = <1>;

[Severity: Medium]
Are the GPIO controller properties missing from this example?

Including gpio-controller and #gpio-cells ensures the example passes
dt_binding_check validation once they are made required properties.

> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-ad4692-multichannel-sar-adc-driver-v13-0-1b7626d3b35c@analog.com?part=1