Re: [PATCH 1/2] dt-bindings: dma: xilinx: Add optional resets property for ZDMA

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `resets` property is added globally without conditional constraints, allowing it to pass validation on older SoCs that do not support it in hardware.
--

commit 832c482914e7639cb1a410d061bf9d631b41ae68
Author: Jay Buddhabhatti <jay.buddhabhatti@amd.com>

dt-bindings: dma: xilinx: Add optional resets property for ZDMA

This commit adds an optional resets property for ZDMA on newer SoCs like
Versal Gen2 and Versal-Net. Older SoCs do not have a reset line provision.

> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index 2da86037ad79e..dff16763e11b9 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> @@ -56,6 +56,9 @@ properties:
>    iommus:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +

[Severity: Medium]
The commit message notes that older SoCs do not support this reset line.
Since the resets property is added to the top-level properties block, will
this allow device trees for older hardware to erroneously define a reset line
and silently pass validation?

Should this be guarded by an allOf conditional block restricting the resets
property to the newer hardware compatible strings?

>    power-domains:
>      maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525105042.2249542-1-nagendra.golla@amd.com?part=1