Re: [PATCH v7 11/18] ASoC: rsnd: Add SSI reset support for RZ/G3E platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The module clock is not enabled before calling reset_control_assert() during module teardown, which can cause the reset propagation to stall and time out.
--

commit ef6d940426384aba7286c552a35eb9b1119adf84
Author: John Madieu <john.madieu.xa@bp.renesas.com>

ASoC: rsnd: Add SSI reset support for RZ/G3E platform

This commit adds SSI reset support for the RZ/G3E platform by acquiring the
per-SSI reset controller and passing it to rsnd_mod_init(). It uses the
rsnd_devm_reset_control_get_optional_indexed() helper to support both new
hyphenated and legacy dotted names.

> diff --git a/sound/soc/renesas/rcar/ssi.c b/sound/soc/renesas/rcar/ssi.c
> index cf98cc9ee44c3..e6734671328c8 100644
> --- a/sound/soc/renesas/rcar/ssi.c
> +++ b/sound/soc/renesas/rcar/ssi.c

[ ... ]

> @@ -1220,7 +1232,7 @@ int rsnd_ssi_probe(struct rsnd_priv *priv)
>  			ops = &rsnd_ssi_dma_ops;
>  
>  		ret = rsnd_mod_init(priv, rsnd_mod_get(ssi), ops, clk,
> -				    NULL, RSND_MOD_SSI, i);
> +				    rstc, RSND_MOD_SSI, i);

[Severity: High]
Does this code stall or panic during module teardown?

While rsnd_mod_init() correctly enables the clock before calling
reset_control_deassert(), the teardown path in rsnd_mod_quit() calls
reset_control_assert() without first enabling the module clock.

Because rsnd_mod_quit() is executed during module teardown when streams are
stopped and module clocks are disabled:

rsnd_mod_quit()
    reset_control_assert(mod->rstc);

Asserting the reset will fail to propagate through the unclocked IP block.

Will this cause the SoC's reset controller driver to time out while polling
the reset monitor bit, leaving the hardware in an inconsistent state?

>  		if (ret)
>  			goto rsnd_ssi_probe_done;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525110230.4014435-1-john.madieu.xa@bp.renesas.com?part=11