Re: [PATCH v4 8/8] arm64: dts: renesas: r9a09g047e57-smarc: add DA7212 audio codec support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unnecessary and schema-violating `#address-cells` and `#size-cells` properties in the `da7212: codec@1a` node.
--

commit 81d96eea4cdb9cf3abc2275fa638509b017cf64e
Author: John Madieu <john.madieu.xa@bp.renesas.com>

arm64: dts: renesas: r9a09g047e57-smarc: add DA7212 audio codec support

This commit enables audio support on the RZ/G3E SMARC2 EVK boards by
adding device tree nodes for the DA7212 audio codec. The codec is
connected via I2C1 and uses SSI3/SSI4 for sound input and output.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> index 6372f582a7c41..7defd342294ad 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts

[ ... ]

> @@ -99,6 +146,37 @@ &i2c0 {
>  	pinctrl-names = "default";
>  };
>  
> +&i2c1 {
> +	da7212: codec@1a {
> +		compatible = "dlg,da7212";
> +		#sound-dai-cells = <0>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;

[Severity: Low]
Are these cell size properties necessary here? Since the child port node
does not have a unit address or a reg property, this triggers an
avoid_unnecessary_addr_size dtc warning.

Additionally, does this cause a dtbs_check validation failure? The binding
schema for this device does not define #address-cells or #size-cells and
sets unevaluatedProperties: false.

> +		reg = <0x1a>;
> +
> +		clocks = <&versa3 1>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525110603.4018170-1-john.madieu.xa@bp.renesas.com?part=8