Re: [PATCH v5 1/5] dt-bindings: thermal: Add Google GS101 TMU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `samsung,acpm-ipc` property is missing from the `required` list despite being functionally mandatory for device operation.
--

commit f4129715b1366153f8c291ba713ab0836fdf5768
Author: Tudor Ambarus <tudor.ambarus@linaro.org>

dt-bindings: thermal: Add Google GS101 TMU

Document the Thermal Management Unit found on the Google GS101 SoC.
This hardware uses a hybrid control model where the Application Processor
delegates high-level functional tasks to the ACPM firmware via IPC.

> diff --git a/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml

[ ... ]

> +  samsung,acpm-ipc:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: Phandle to the ACPM IPC node.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +  - "#thermal-sensor-cells"

[Severity: Medium]
Since the commit message and binding description indicate that the
Application Processor relies entirely on the ACPM firmware for all
functional TMU tasks, shouldn't samsung,acpm-ipc be included in this
required list?

Without it, incomplete device tree nodes might silently pass schema
validation.

> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-acpm-tmu-v5-0-85fde739752e@linaro.org?part=1