Re: [PATCH v2 1/2] dt-bindings: i3c: add Realtek RTS490x I3C HUB

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The binding supports configuring target ports as GPIOs but is missing the required standard GPIO provider properties (`gpio-controller`, `#gpio-cells`).
- [Medium] The commit message claims configuration properties that are missing from the schema or incorrectly described.
--

commit 7ef74db38a704236da2879cdad3537af86a4d897
Author: Yin Zhou <zain_zhou@realsil.com.cn>

dt-bindings: i3c: add Realtek RTS490x I3C HUB

This commit adds the device tree binding schema for the Realtek RTS490x series
I3C HUB devices. It describes configuration properties such as LDO voltage,
pull-up resistance, IO driver strength, and per-port operating modes.

>     The binding describes configuration properties for:
>       - LDO enable/disable and voltage level per port group
>       - Pull-up resistance per port group
>       - IO driver strength per port
>       - Per target-port mode (I3C/SMBus/GPIO/disabled), pull-up,
>         IO mode, SMBus clock frequency and polling interval
>       - Hub network always-I3C mode

[Severity: Medium]
Does the commit message accurately reflect the properties added in the schema?

The schema defines IO driver strength per port group (e.g.,
realtek,tp0145-io-strength-ohms) rather than per individual port as claimed.

Additionally, properties for 'Hub network always-I3C mode' and 'IO mode'
appear to be missing from the schema definition completely.

> diff --git a/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml b/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml
> new file mode 100644
> index 0000000000000..851a433abcd3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml
[ ... ]
> +patternProperties:
> +  "^target-port@[0-9]+$":
> +    type: object
> +    description:
> +      I3C HUB target port child node, named target-port@<id>.
> +
> +    properties:
[ ... ]
> +      realtek,mode:
> +        enum: [disabled, i3c, smbus, gpio]

[Severity: Medium]
Should the schema define the standard GPIO provider properties here?

According to the dt-bindings subsystem guidelines, when a hardware variant
introduces GPIO provider capabilities (as enabled by the gpio mode here),
the schema must include the standard provider properties gpio-controller
and #gpio-cells in the definition and required lists, as well as in the
examples.

Without these, unevaluatedProperties: false will reject them if provided,
and dependent drivers or subsystems may fail at runtime if they are omitted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525125128.297-1-zain_zhou@realsil.com.cn?part=1