Re: [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `Fixes` tag in the commit message incorrectly points to the commit that moved the DTS file rather than the one that introduced the issue.
--

commit fdcc6b03fb02176ae8f78463b918136ece476e62
Author: Jun Yan <jerrysteve1101@gmail.com>

ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity

This commit corrects the sn3193 shutdown GPIO polarity from GPIO_ACTIVE_HIGH
to GPIO_ACTIVE_LOW to match the hardware specification.

> The sn3193 shutdown pin is active-low[1]. Correct the GPIO flags
> from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware.
> 
> [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
> 
> Fixes: 724ba6751532 ("ARM: dts: Move .dts files to vendor sub-directories")

[Severity: Medium]
Does this Fixes tag point to the correct commit? Commit 724ba6751532 appears
to be a structural tree reorganization that just moved the DTS file. 

The led-controller@68 node with the faulty GPIO_ACTIVE_HIGH flag seems to
have been originally introduced in commit 3835f9a0cf56 ("ARM: dts: qcom:
msm8974-oneplus-bacon: Add notification LED").

Pointing to a file-move commit might break automated backporting to stable
kernels.

> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525144629.498630-1-jerrysteve1101@gmail.com?part=5