Devicetree
 help / color / mirror / Atom feed
From: Liviu Stan <liviu.stan@analog.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Francesco Lavra" <flavra@baylibre.com>,
	"Liviu Stan" <liviu.stan@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@analog.com, devicetree@vger.kernel.org
Subject: [PATCH v4 1/9] iio: temperature: ltc2983: Fix n_wires default bypassing rotation check
Date: Mon, 25 May 2026 19:39:28 +0300	[thread overview]
Message-ID: <20260525164013.118614-2-liviu.stan@analog.com> (raw)
In-Reply-To: <20260525164013.118614-1-liviu.stan@analog.com>

When adi,number-of-wires is absent, n_wires is left at 0. The binding
documents a default of 2 wires, matching the hardware default. However
the current-rotate validation checks n_wires == 2 || n_wires == 3, so
with n_wires = 0 the guard is bypassed and adi,current-rotate is accepted
for a 2-wire RTD.

Initialize n_wires = 2 to match the binding default and ensure the
rotation check fires correctly when the property is absent.

Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
Signed-off-by: Liviu Stan <liviu.stan@analog.com>
---
Changes in v4:
- Moved to the front of the series

 drivers/iio/temperature/ltc2983.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index 38e6f8dfd3b8..1f835e326b93 100644
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -741,7 +741,7 @@ ltc2983_rtd_new(const struct fwnode_handle *child, struct ltc2983_data *st,
 	struct ltc2983_rtd *rtd;
 	int ret = 0;
 	struct device *dev = &st->spi->dev;
-	u32 excitation_current = 0, n_wires = 0;
+	u32 excitation_current = 0, n_wires = 2;
 
 	rtd = devm_kzalloc(dev, sizeof(*rtd), GFP_KERNEL);
 	if (!rtd)
-- 
2.43.0


  reply	other threads:[~2026-05-25 16:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 16:39 [PATCH v4 0/9] iio: temperature: ltc2983: Add support for ADT7604 Liviu Stan
2026-05-25 16:39 ` Liviu Stan [this message]
2026-05-27 16:11   ` [PATCH v4 1/9] iio: temperature: ltc2983: Fix n_wires default bypassing rotation check Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 2/9] iio: temperature: ltc2983: Fix reinit_completion() called after conversion start Liviu Stan
2026-05-27 16:13   ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 3/9] iio: temperature: ltc2983: Fix macro parenthesization and rename Liviu Stan
2026-05-27 16:13   ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 4/9] iio: temperature: ltc2983: Use local device pointer consistently Liviu Stan
2026-05-27 16:18   ` Jonathan Cameron
2026-06-02 23:25     ` Andy Shevchenko
2026-06-03 14:08       ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 5/9] iio: temperature: ltc2983: Fix inconsistent channel wording in messages Liviu Stan
2026-05-27 16:19   ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 6/9] iio: temperature: ltc2983: Use fwnode_property_present() for optional properties Liviu Stan
2026-05-27 16:19   ` Jonathan Cameron
2026-06-02 23:26     ` Andy Shevchenko
2026-06-03 14:01       ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 7/9] iio: core: Add IIO_COVERAGE channel type Liviu Stan
2026-05-27 16:51   ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 8/9] dt-bindings: iio: temperature: Add ADT7604 support to adi,ltc2983 Liviu Stan
2026-05-25 18:28   ` sashiko-bot
2026-05-26 16:55   ` Conor Dooley
2026-05-27 15:59     ` Liviu Stan
2026-05-27 16:51     ` Jonathan Cameron
2026-05-25 16:39 ` [PATCH v4 9/9] iio: temperature: ltc2983: Add support for ADT7604 Liviu Stan
2026-05-25 19:06   ` sashiko-bot
2026-05-26  8:47   ` Liviu Stan
2026-05-27 16:49     ` Jonathan Cameron
2026-06-02  6:38       ` Liviu Stan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525164013.118614-2-liviu.stan@analog.com \
    --to=liviu.stan@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=flavra@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox