Re: [PATCH v9 2/3] media: dt-bindings: Add CSI Pixel Formatter DT bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Unit address mismatch in the example's syscon parent node.
- [Low] Missing 'ranges' property in the parent syscon node in the example.
- [Low] Poor formatting in the device tree example block.
--

commit 1b3ddadbdea2fb3bc19aa036199bd1e0ef56413b
Author: Guoniu Zhou <guoniu.zhou@nxp.com>

media: dt-bindings: Add CSI Pixel Formatter DT bindings

This commit adds the device tree binding schema for the i.MX95 CSI pixel
formatter module. It defines the constraints and ports required to interface
the CSI-2 host controller with the Pixel Link definition.

> diff --git a/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml
> new file mode 100644
> index 0000000000000..61068ea0a69a0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/clock/nxp,imx95-clock.h>
> +
> +    syscon@4c100000 {
> +        compatible = "nxp,imx95-camera-csr", "syscon";
> +        reg = <0x4ac10000 0x10000>;

[Severity: Low]
This isn't a bug, but the unit address in the node name (4c100000) does not
match the base address specified in the reg property (0x4ac10000). Should the
node be named syscon@4ac10000 to match the reg property and avoid unit_address
validation warnings?

> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        #clock-cells = <1>;
> +        clocks = <&scmi_clk 62>;
> +        power-domains = <&scmi_devpd 3>;

[Severity: Low]
Does this syscon parent node need a ranges property?

Because it specifies address and size cells and contains a memory-mapped
child node (formatter@20), omitting the ranges property prevents correct
address translation for the child node and typically results in dtc warnings.

> +
> +        formatter@20{

[Severity: Low]
This isn't a bug, but there is a missing space before the opening brace.

> +            compatible = "fsl,imx95-csi-formatter";
> +            reg = <0x20 0x100>;
[ ... ]
> +                port@0 {
> +                    reg = <0>;
> +
> +                    endpoint {
> +                        remote-endpoint = <&mipi_csi_0_out>;
> +                    };
> +
> +               };

[Severity: Low]
This isn't a bug, but the closing brace here is indented incorrectly compared
to the rest of the block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-csi_formatter-v9-0-ca3d8c334c39@oss.nxp.com?part=2