Re: [PATCH RFC 2/2] arm64: dts: qcom: kodiak: Fix up LPASS TX macro v9.4 control names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] Critical ABI Breakage: Unilateral ALSA control rename breaks userspace UCM and DT backward/forward compatibility.
- [Low] Binding Schema Consistency: YAML device tree binding example retains obsolete audio routing strings.
--

commit e8146d6a5dc9b62baace794be0e79e57fb705798
Author: Luca Weiss <luca.weiss@fairphone.com>

arm64: dts: qcom: kodiak: Fix up LPASS TX macro v9.4 control names

This commit updates the audio routing properties in several Qualcomm device
trees to reflect changes in the LPASS TX macro v9.4 control names.
Specifically, it renames "TX SWR_ADC" and "TX SWR_DMIC" to "TX SWR_INPUT".

> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902b..565f7db91e77c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -860,7 +860,7 @@ &sound {
>  			"TX DMIC0", "MIC BIAS1",
>  			"TX DMIC1", "MIC BIAS2",
>  			"TX DMIC2", "MIC BIAS3",
> -			"TX SWR_ADC1", "ADC2_OUTPUT",
> +			"TX SWR_INPUT1", "ADC2_OUTPUT",

[Severity: Critical]
Does changing these control names without providing an alias break existing
userspace ALSA UCM configurations?

Since older device trees and userspace setups might still expect the
"TX SWR_ADC" and "TX SWR_DMIC" routing strings, does this unilateral rename
cause backward and forward compatibility regressions for systems relying on
the previous names?

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
> index ce48e4cda1708..bc492346f7dc2 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
> @@ -20,17 +20,17 @@ sound: sound {
>  			"VA DMIC1", "MIC BIAS1",
>  			"VA DMIC2", "MIC BIAS3",
>  			"VA DMIC3", "MIC BIAS3",
> -			"TX SWR_ADC0", "ADC1_OUTPUT",
> -			"TX SWR_ADC1", "ADC2_OUTPUT",
> -			"TX SWR_ADC2", "ADC3_OUTPUT",
> -			"TX SWR_DMIC0", "DMIC1_OUTPUT",
> -			"TX SWR_DMIC1", "DMIC2_OUTPUT",
> +			"TX SWR_INPUT0", "ADC1_OUTPUT",
> +			"TX SWR_INPUT1", "ADC2_OUTPUT",
> +			"TX SWR_INPUT2", "ADC3_OUTPUT",
> +			"TX SWR_INPUT4", "DMIC1_OUTPUT",
> +			"TX SWR_INPUT5", "DMIC2_OUTPUT",

[Severity: Low]
Does the device tree binding example for this hardware also need updating?

The schema at Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
still contains the obsolete "TX SWR_ADC" and "TX SWR_DMIC" audio routing
strings in its example section, which might now be out of sync with these
driver updates.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-sc7280-tx-macro-v1-0-1aad6900fec0@fairphone.com?part=2