Re: [PATCH 3/3] regulator: 88pm886: Add Vbus regulator

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced `pm886_vbus_regulator` structure contains function pointers but is allocated in read-write memory instead of read-only memory.
--

commit 133b6ca9034767cb2bdba63244660bc0872522af
Author: Duje Mihanović <duje@dujemihanovic.xyz>

regulator: 88pm886: Add Vbus regulator

This commit adds support for the PMIC's Vbus regulator to the 88pm886
driver. This regulator is mandatory for USB OTG support on boards using
this PMIC.

> diff --git a/drivers/regulator/88pm886-regulator.c b/drivers/regulator/88pm886-regulator.c
> index a38bd4f312b72..039822e86ec87 100644
> --- a/drivers/regulator/88pm886-regulator.c
> +++ b/drivers/regulator/88pm886-regulator.c
[ ... ]
> @@ -337,6 +338,25 @@ static struct regulator_desc pm886_regulators[] = {
>  	},
>  };
>  
> +static const struct linear_range pm886_vbus_volt_ranges[] = {
> +	REGULATOR_LINEAR_RANGE(3750000, 0, 7, 250000)
> +};
> +
> +static struct regulator_desc pm886_vbus_regulator = {

[Severity: Low]
This isn't a bug, but should this pm886_vbus_regulator structure be declared
as const so it is placed in read-only memory?

While the existing pm886_regulators array also lacks the const qualifier,
making this change would require updating the local rdesc pointer in
pm886_regulator_probe to be a const struct regulator_desc pointer.

> +	.name = "vbus",
> +	.regulators_node = "regulators",
> +	.of_match = "vbus",
> +	.ops = &pm886_buck_ops,
> +	.type = REGULATOR_VOLTAGE,
> +	.n_voltages = 8,
> +	.linear_ranges = pm886_vbus_volt_ranges,
> +	.n_linear_ranges = ARRAY_SIZE(pm886_vbus_volt_ranges),
> +	.vsel_reg = PM886_REG_BOOST_CONFIG1,
> +	.vsel_mask = PM886_REG_BOOST_MASK,
> +	.enable_reg = PM886_REG_BATTERY_CONFIG1,
> +	.enable_mask = PM886_REG_VBUS_EN,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-88pm886-vbus-v1-0-f2bd1fd3c19e@dujemihanovic.xyz?part=3