From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 070123A6F0F for ; Wed, 27 May 2026 10:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779876422; cv=none; b=Fu390Ll+/fg2wyNXohoZmLwpm9+Q27KRT3X6NF7mM0BOkHsHrhuxvRenMAB3t88RT+cYgYpXFi1VLvBvUICQlC3tKVuDmLUV9BjBsPpqDkpU/5lT8yD9o0bKmin0b/ABucMsxWdu72M1QgKLhE+HK5idBZ18k4NyvVJGLWcqR6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779876422; c=relaxed/simple; bh=acbcX64bYb98LaRdbT6+Y868f2X9HTaKHim/ofFo0XA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=c6rcyfPeT6SOqnziiaYFUxQTOP9TokS1MLnuX45vVEVQ5Ki5kD6t1c74YhW1AEdLEoc8tr6oMxrnB/cZAf4cOyO5avHiwb4dhEgFj9EMoIu58Pc9wPGaPQ0qfzj0lRFePbwvKaf7sSQzQ9i+XPOJu6NycIaSujo2qjyl1Zwiw0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H5Xh+iRv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H5Xh+iRv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 725661F000E9; Wed, 27 May 2026 10:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779876420; bh=iBYL8n9+CaYjeL/kQd6JTucpQw0cjC2doS/hzeaMRbA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=H5Xh+iRvjSD8UIB1psVBFqqhPVANF7sG1eYwU6jT5LcCdW5NBJ42q31nvBSdQuP68 sqbvwEF072kgtmiorulNWJgWZFL8IW2GrXqG9LGBF7GINsT0CwZEa9feG8W+taRrRs Z8c5ebiX+N9GFrxml5oksCbsLa/n0X3ORNtxeFwKZ8VcgDHi2M6HTOC0oTMt+TItXt 9HkEKSakuEN9mpN19dP7pEMwY19ges5Aex9xJFJeLb9mbzCgrvbOckgbF4SjnYFp+Y 8dp1t3Dpx39pV/k69HqppYvY4tGy7beK4iolpx02ahIIY87JDPpZnPwbCtW0b6Yg5d rBG0rkWv9wqQQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 06/24] arm64: dts: qcom: sc8180x: Reduce OS PDC DRV span to 0x10000 Reply-To: sashiko-reviews@lists.linux.dev To: "Mukesh Ojha" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260527094333.2311731-7-mukesh.ojha@oss.qualcomm.com> References: <20260527094333.2311731-7-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 27 May 2026 10:07:00 +0000 Message-Id: <20260527100700.725661F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Reducing the `reg` property size to 0x10000 in the device tree t= riggers a hardcoded override and a boot warning in the PDC driver, failing = to actually reduce the mapped memory size. -- commit 801af88b2159c6cae68a0fa2faaac6413c1a3461 Author: Mukesh Ojha arm64: dts: qcom: sc8180x: Reduce OS PDC DRV span to 0x10000 The OS PDC DRV register window on sc8180x spans 0x10000 bytes. Reduce the size of the first reg entry from 0x30000 to 0x10000. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/= qcom/sc8180x.dtsi > index f45deb188c6c0..bafdbcd329e9a 100644 > --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi > @@ -3554,7 +3554,7 @@ dispcc: clock-controller@af00000 { > =20 > pdc: interrupt-controller@b220000 { > compatible =3D "qcom,sc8180x-pdc", "qcom,pdc"; > - reg =3D <0 0x0b220000 0 0x30000>; > + reg =3D <0 0x0b220000 0 0x10000>; [Severity: Medium] Will this change actually reduce the mapped memory size, or will it just trigger a warning on boot? Looking at the qcom-pdc driver in drivers/irqchip/qcom-pdc.c, there is a hardcoded minimum size check for the reg property: drivers/irqchip/qcom-pdc.c:qcom_pdc_probe() { ... res_size =3D max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE); if (res_size > resource_size(&res)) pr_warn("%pOF: invalid reg size, please fix DT\n", node); ... pdc_base =3D ioremap(res.start, res_size); ... } Since QCOM_PDC_SIZE is 0x30000, passing a size of 0x10000 here will cause t= he driver to expand the mapped memory back to 0x30000 and emit a warning on ev= ery boot. Does the driver logic need to be updated alongside this device tree change = to prevent this warning and successfully reduce the memory footprint? > qcom,pdc-ranges =3D <0 480 94>, <94 609 31>; > #interrupt-cells =3D <2>; > interrupt-parent =3D <&intc>; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260527094333.2311= 731-1-mukesh.ojha@oss.qualcomm.com?part=3D6