From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073373D9666; Wed, 27 May 2026 16:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779898798; cv=none; b=iKRBXsp9kW/5gm01c/Zuu7aWtb6ZGyR8Y9z7vUkWBSpL/XBk0BHQ+SWm3h3dJ8Ck4YfPn+4vLrR1xNv3dftj1cOyK/p8LIxJNV/y16JieomXhJXTyfwaoqZkf8IyuuyGlhfnBBNRYOUK2o+z7o3MYJKl/kjQAMaUnUGtOhQmR4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779898798; c=relaxed/simple; bh=diw6DfX3hqqSnCF/5WnRkWxmMOKFIUOdvBXDdtmW/UY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E5uEOwKwoSDFIj9Ja+yXe9HOvs1LkVtfTH0y4dAQjBJaKs8sKNl2wxs4n4UQvysW2ViWBSzeKhITsge3l8bPbZp8svHbe1DCioHRs/HQrGjlFuNKN623SJe9XNK1VzERNBuz1L/iA0e9E5pTZIHKzgCUQJGi1XvOeOBqaLHB8yI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GoczDKjX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GoczDKjX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 705631F000E9; Wed, 27 May 2026 16:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779898796; bh=cfPSPvTQxiWwPSDOrblA3fessS8xjp+I+8xBSFClGFQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=GoczDKjXXmJvGuYc/P7zy2HU72zYWnF9hcIzRRIW8HPotw5uyL1K/WkrO90O1PBHU gYiLp14pG3xleJbvOigCgjVbueVk9qh4sqNv2u+FUObLl+zm9Q4VO5Aq0IJp9Vvyla K8HP8i3N7bMejVmkdAv6j9aiZ551NVvxSxKbLXIMmd5nrGtDoqqOftTsIqQRAWqihy Z8oPRVhNJTWKYB/VM8FGXFi0RUibltK/f5IxItXYrvWLa1laAZXsL5XGMUgu/+fhqb zR67VF9EVvqlh2+skDpKVTZ3Fvn3CXqOhiE8ufrkR5Lsw1kePSsQPu4pkGH6diik9f RDXLRcY5ccpQw== Date: Wed, 27 May 2026 17:19:45 +0100 From: Jonathan Cameron To: Liviu Stan Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Antoniu Miclaus , Francesco Lavra , , , , Subject: Re: [PATCH v4 6/9] iio: temperature: ltc2983: Use fwnode_property_present() for optional properties Message-ID: <20260527171945.152279fa@jic23-huawei> In-Reply-To: <20260525164013.118614-7-liviu.stan@analog.com> References: <20260525164013.118614-1-liviu.stan@analog.com> <20260525164013.118614-7-liviu.stan@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 25 May 2026 19:39:33 +0300 Liviu Stan wrote: > Checking fwnode_property_read_u32() return value with if (!ret) > silently swallows meaningful error codes when a property is present > but malformed. Use fwnode_property_present() first so that absence > uses the default while a present but unreadable property returns > a proper error. > > Signed-off-by: Liviu Stan Applied, Thanks, Jonathan