Re: [PATCH v10 04/11] dt-bindings: iio: adc: hx711: add HX710B support

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 25 May 2026 18:01:41 +0100
Conor Dooley <conor@kernel.org> wrote:

> Jonathan,
> 
> Here's an example of the sort of stuff it complains about on every
> iteration.
> 
Thanks. +cc linux-iio@vger.kernel.org

> On Mon, May 25, 2026 at 11:11:44AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> > - [Medium] The `dvdd-supply` property is utilized by the HX710B and mentioned in the commit message, but it is not enforced as a required property for the new compatible or included in the example.
Yup. This stuff needs fixing.

> > - [Low] The `if` condition for the `avia,hx710b` compatible incorrectly uses `const` instead of `contains: const`, causing schema validation to always fail for HX710B nodes.

This one I'm not sure on. Is it right?  I tested by hacking
the example to have a supply it shouldn't and the schema validation failed
as expected making me think this is a false positive.
I have zero natural feel for yaml so no idea :)

+CC linux-iio@vger.kernel.org


> > --
> > 
> > commit 006ef740da7a1ce47e48ea34371f93f0e9dd9a9a
> > Author: Piyush Patle <piyushpatle228@gmail.com>
> > 
> > dt-bindings: iio: adc: hx711: add HX710B support
> >     
> > Add the avia,hx710b compatible and document the HX710B-specific
> > DVDD and VREF supplies. Add constraints that forbid HX711-only
> > properties on HX710B nodes and require vref-supply for HX710B,
> > then add a separate HX710B example.
> >   
> > >     Add the avia,hx710b compatible and document the HX710B-specific
> > >     DVDD and VREF supplies.  
> > 
> > [Severity: Medium]
> > The commit message mentions documenting the DVDD supply, and the binding
> > description notes the HX710B measures the DVDD-AVDD supply voltage difference.
> > However, dvdd-supply is not enforced as a required property for the new
> > compatible, nor is it included in the new example node.
> > 
> > Should dvdd-supply be added to the required properties and the example to
> > ensure complete schema constraints?
> > 
> > [ ... ]
> >   
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > index 099235b5fd548..f0aeb15e9eb9e 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml  
> > [ ... ]  
> > > @@ -62,6 +71,21 @@ properties:
> > >      maximum: 2500000
> > >      default: 400000
> > >  
> > > +allOf:
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: avia,hx710b  
> > 
> > [Severity: Low]
> > Is this the correct way to match the compatible string? Since the compatible
> > property is evaluated as a string array, using a strict scalar comparison here
> > evaluates to false, causing the schema to always fall through to the else block.
> > 
> > Would it be better to use contains: const: avia,hx710b instead so that it
> > properly evaluates the array and enforces the constraints in the then block?
> >   
> > > +    then:
> > > +      properties:
> > > +        vsup-supply: false
> > > +        rate-gpios: false  
> > 
> > -- 
> > Sashiko AI review · https://sashiko.dev/#/patchset/20260525105127.180156-1-piyushpatle228@gmail.com?part=4