Re: [PATCH v30 1/5] dt-bindings: i2c: Split AST2600 binding into a new YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims the binding requires two `reg` regions, but the schema specifies `minItems: 1`, making the second region optional.
--

commit 1bb6224b110a8990b3c95cd44d683d1ba249d994
Author: Ryan Chen <ryan_chen@aspeedtech.com>

dt-bindings: i2c: Split AST2600 binding into a new YAML

This commit separates the AST2600 I2C controller bindings from the older
AST2400/AST2500 schemas into a dedicated file. It also updates the schema
to enforce AST2600-specific constraints like interrupts, clock frequencies,
and register regions.

> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,ast2600-i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,ast2600-i2c.yaml
> new file mode 100644
> index 0000000000000..abc614315dffb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,ast2600-i2c.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - aspeed,ast2600-i2c-bus
> +
> +  reg:
> +    minItems: 1

[Severity: Medium]
The commit message states that this binding adjusts AST2600-specific
requirements to "require two reg regions (controller register block + buffer
block)".

Should minItems be set to 2 here to enforce that requirement? Setting it
to 1 makes the second region optional, which allows device tree nodes with
only a single reg region to silently pass schema validation.

> +    items:
> +      - description: controller registers
> +      - description: controller buffer space

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528-upstream_i2c-v30-0-5d4f9adc3530@aspeedtech.com?part=1