From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] ARM: dts: gemini: Fix partition offsets
Date: Thu, 28 May 2026 08:37:53 +0000 [thread overview]
Message-ID: <20260528083754.5FD531F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260528-gemini-fix-sq201-fis-offset-v2-1-f594d3072fe6@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message contains a mathematical error in the erase block size calculation.
--
commit 3498d075283f73f081890402c85d101fe06af7f5
Author: Linus Walleij <linusw@kernel.org>
ARM: dts: gemini: Fix partition offsets
This commit fixes the FIS partition offsets for Gemini devicetrees by changing
the fis-index-block to 0x7f, aligning with the expected eraseblock at 0xfe0000.
> These FIS partition offsets were never right: the comment clearly
> states the FIS index is at 0xfe0000 and 0x7f * 0x200000 is
> 0xfe0000.
[Severity: Medium]
Is the block size multiplier in this description accurate? 0x7f multiplied by
0x200000 is actually 0xfe00000. To reach 0xfe0000, the multiplier would need
to be 0x20000. Could the commit message be updated to reflect the correct
erase block size?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260528-gemini-fix-sq201-fis-offset-v2-1-f594d3072fe6@kernel.org?part=1
next prev parent reply other threads:[~2026-05-28 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 8:25 [PATCH v2] ARM: dts: gemini: Fix partition offsets Linus Walleij
2026-05-28 8:37 ` sashiko-bot [this message]
2026-05-28 13:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528083754.5FD531F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linusw@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox