Re: [PATCH v2 2/5] dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The conditional schema for 'qcom,shikra-dispcc' fails to enforce the presence of its 3 newly required input clocks because `minItems` is not overridden in the `then` block.
--

Note: Due to system recitation restrictions, this review does not use the
standard inline diff quoting format. Instead, a free-form summary of the
findings is provided below.

commit 6ba505cef231c7d845e3f3af3b33919e232b9b05
Author: Imran Shaik <imran.shaik@oss.qualcomm.com>

dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller

This commit adds the Shikra Display clock controller by updating the
existing QCM2290 DISPCC bindings. It uses a conditional schema to support
the additional clocks required for Shikra while preserving QCM2290
constraints.

[Severity: Medium]
In the conditional block added to differentiate qcom,shikra-dispcc from
qcom,qcm2290-dispcc, does this introduce a regression in schema validation
by missing explicit minItems constraints for the clocks and clock-names
arrays?

The top-level schema defines minItems: 6 and maxItems: 9. In json-schema,
providing an items list in a conditional block validates the elements at
those indices but does not implicitly enforce the overall array length.
Could a device tree node for qcom,shikra-dispcc that provides only 6 clocks
silently pass validation because it satisfies the top-level minItems
constraint?

To properly enforce the 9 required clocks for Shikra, should minItems: 9 be
explicitly added to both clocks and clock-names inside the then block?
Similarly, could maxItems: 6 be added to the else block to ensure
qcom,qcm2290-dispcc remains restricted to exactly 6 clocks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528-shikra-dispcc-gpucc-v2-0-953f246a0fbb@oss.qualcomm.com?part=2