Re: [PATCH v6 2/5] dt-bindings: timer: econet: Update EN751627 for multi-IRQ

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The commit modifies the `compatible` property to remove the fallback and strictly require 4 interrupts for the `econet,en751627-timer`, breaking backwards compatibility with existing device trees.
--

commit 4d76d221e102e3fd0badbb607f955a94dc92884a
Author: Caleb James DeLisle <cjd@cjdns.fr>

dt-bindings: timer: econet: Update EN751627 for multi-IRQ

This commit updates the device tree binding for the EN751627 timer. It 
modifies the binding to require an individual IRQ number per timer instead 
of a single shared percpu IRQ.

> diff --git a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> --- a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
[ ... ]
>  properties:
>    compatible:
> -    oneOf:
> -      - const: econet,en751221-timer
> -      - items:
> -          - const: econet,en751627-timer
> -          - const: econet,en751221-timer
> +    enum:
> +      - econet,en751221-timer
> +      - econet,en751627-timer

[ ... ]

> @@ -52,21 +51,31 @@ allOf:
>            items:
>              - description: VPE timers 0 and 1
>              - description: VPE timers 2 and 3
> +        interrupts:
> +          description: An interrupt for each timer (one per VPE)
> +          minItems: 4

[Severity: High]
Does this change break backwards compatibility with existing device trees?

The previous schema allowed compatible = "econet,en751627-timer",
"econet,en751221-timer" with a single interrupt. 

Modifying the compatible property to an enum without the fallback and enforcing
minItems: 4 for interrupts on the en751627-timer means any existing device tree
using the old schema will now fail validation.

Can this cause boot regressions on previously functioning deployed systems if
an updated driver expects 4 interrupts and attempts to index into an
uninitialized IRQ array?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528140046.2897674-1-cjd@cjdns.fr?part=2