Re: [PATCH RFC v3 1/5] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The file pattern added to the MAINTAINERS file does not match the actual path of the newly added device tree binding.
- [Low] The devicetree example uses a non-standard generic node name `clk` instead of `clock-controller`.
--

commit aa0b3a597f8880d6044f62a15d10b6b5492211b1
Author: Stefan Dösinger <stefandoesinger@gmail.com>

dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings.

This commit introduces device tree bindings for the ZTE zx297520v3 top clock
and reset controllers, modeling them as a single device with two memory
regions. It also adds a related header file for clock and reset definitions
and updates the MAINTAINERS file.

> diff --git a/Documentation/devicetree/bindings/clock/zte,zx297520v3-topclk.yaml b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topclk.yaml
> new file mode 100644
> index 0000000000000..968820bde7558
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topclk.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/zte,zx297520v3-clk.h>
> +
> +    osc26m: osc26m {
> +      compatible = "fixed-clock";
> +      clock-frequency = <26000000>;
> +      #clock-cells = <0>;
> +    };
> +
> +    osc32k: osc32k {
> +      compatible = "fixed-clock";
> +      clock-frequency = <32768>;
> +      #clock-cells = <0>;
> +    };
> +
> +    topclk: clk@13b000 {

[Severity: Low]
Does this generic node name violate the devicetree specification? The standard 
naming convention for clock providers expects clock-controller instead of clk,
which might trigger warnings during a make dt_binding_check run.

> +        compatible = "zte,zx297520v3-topclk";
> +        reg = <0x0013b000 0x400>,
> +              <0x01306000 0x400>;
> +        reg-names = "top", "matrix";
> +        #clock-cells = <1>;
> +        #reset-cells = <1>;
> +        clocks = <&osc26m>, <&osc32k>;
> +        clock-names = "osc26m", "osc32k";
> +    };

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4ae1e77c2fd78..ae51d590d4403 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3864,8 +3864,10 @@ L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>  S:	Odd fixes
>  F:	Documentation/arch/arm/zte/
>  F:	Documentation/devicetree/bindings/arm/zte.yaml
> +F:	Documentation/devicetree/zte,zx297520v3-*

[Severity: Low]
Is the path in this pattern correct? The new device tree binding file is created
at Documentation/devicetree/bindings/clock/zte,zx297520v3-topclk.yaml, so 
missing the bindings/clock/ directory components means this wildcard won't match 
the new file.

>  F:	arch/arm/boot/dts/zte/
>  F:	arch/arm/mach-zte/
> +F:	include/dt-bindings/clock/zte,zx297520v3-clk.h

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-zx29clk-v3-0-c7fe54ea388f@gmail.com?part=1