From: sashiko-bot@kernel.org
To: "Alessio Ferri" <alessio.ferri@mythread.it>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] bus: add BCM6362 on-chip WLAN SHIM bridge driver
Date: Fri, 29 May 2026 02:02:50 +0000 [thread overview]
Message-ID: <20260529020250.830721F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260529-add-bcm6362-wlan-v1-4-722242777f58@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `BCM6362_WLAN_SHIM` Kconfig entry selects `BCMA` and `BCMA_HOST_SOC` without inheriting their hardware dependencies (`HAS_IOMEM` and `HAS_DMA`), leading to unmet direct dependency warnings under `COMPILE_TEST`.
--
commit 1aef741e07978e7d0f4c1dd259cf899630d9e65e
Author: Alessio Ferri <alessio.ferri@mythread.it>
bus: add BCM6362 on-chip WLAN SHIM bridge driver
This commit adds a bridge driver to bring up the BCM6362 on-chip WLAN SHIM
block. It configures clocks and toggles resets, then creates a brcm,bus-axi
child platform device for the bcma driver to enumerate.
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 3181d8aa32a3e..e992a34c52308 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -29,6 +29,19 @@ config ARM_INTEGRATOR_LM
> Say y here to enable support for the ARM Logic Module bus
> found on the ARM Integrator AP (Application Platform)
>
> +config BCM6362_WLAN_SHIM
> + tristate "BCM6362 on-chip WLAN SHIM bridge"
> + depends on BMIPS_GENERIC || COMPILE_TEST
> + depends on OF
> + select BCMA
> + select BCMA_HOST_SOC
[Severity: Low]
Since BCMA depends on HAS_IOMEM and HAS_DMA (via BCMA_POSSIBLE), and
BCMA_HOST_SOC depends on HAS_IOMEM, will selecting them here without
inheriting those hardware dependencies cause unmet direct dependency
warnings?
When COMPILE_TEST is enabled on architectures lacking these capabilities
(such as UML), forcing these symbols on with select might trigger Kconfig
warnings or build failures.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-add-bcm6362-wlan-v1-0-722242777f58@gmail.com?part=4
prev parent reply other threads:[~2026-05-29 2:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 0:05 [PATCH 0/4] bcma: support SHIM-attached big-endian SoC backplanes (BCM6362) Alessio Ferri
2026-05-29 0:05 ` [PATCH 1/4] bcma: support driver specific quirks from soc pdata Alessio Ferri
2026-05-29 0:48 ` sashiko-bot
2026-05-29 0:06 ` [PATCH 2/4] bcma: allow SHIM-style mini-EROM wrapper-less cores in scan Alessio Ferri
2026-05-29 1:25 ` sashiko-bot
2026-05-29 0:06 ` [PATCH 3/4] dt-bindings: bus: add brcm,bcm6362-wlan Alessio Ferri
2026-05-29 1:36 ` sashiko-bot
2026-05-30 11:50 ` Krzysztof Kozlowski
2026-05-29 0:06 ` [PATCH 4/4] bus: add BCM6362 on-chip WLAN SHIM bridge driver Alessio Ferri
2026-05-29 2:02 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529020250.830721F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alessio.ferri@mythread.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox