Re: [PATCH v3 2/2] arm64: dts: qcom: Add Microsoft Surface Pro 12in

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] LDO regulators defined across PMICs c, d, e, i, and j are missing their corresponding parent 'vdd-lX-supply' properties.
--

commit ad40084fe87bf7f45bba2d17354ba7647d363116
Author: Harrison Vanderbyl <harrison.vanderbyl@gmail.com>

arm64: dts: qcom: Add Microsoft Surface Pro 12in

This commit introduces the initial device tree for the Microsoft Surface
Pro 12in based on the Snapdragon X Elite platform. It enables basic
hardware support including ufs, touchscreen, display, and various
connectivity peripherals.

> diff --git a/arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts b/arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts
> new file mode 100644
> index 0000000000000..983966e123e55
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts
[ ... ]
> +	regulators-6 {
> +		compatible = "qcom,pm8550ve-rpmh-regulators";
> +		qcom,pmic-id = "i";
> +
> +		vdd-l1-supply = <&vreg_s4c_1p8>;
> +		vdd-l2-supply = <&vreg_s5j_1p2>;
> +		vdd-s1-supply = <&vph_pwr>;
> +		vdd-s2-supply = <&vph_pwr>;

[Severity: High]
Are we missing the parent supply properties (such as vdd-l3-supply) for the
ldos defined across pmics c, d, e, i, and j?

Without linking these child ldos to their active parent buck converters on this
board (for example, vreg_s1i_0p9), the regulator core cannot track the hardware
dependency hierarchy.

Because the parent buck converter has no explicitly recorded consumers in the
device tree, will the Linux regulator core forcefully disable it during late
initcall as an unused regulator?

Since ldos like vreg_l3i_0p8 supply essential components such as the ufs phy,
could this regression disconnect the storage and result in an unavoidable
kernel panic?

> +
> +		vreg_s1i_0p9: smps1 {
> +			regulator-name = "vreg_s1i_0p9";
> +			regulator-min-microvolt = <900000>;
> +			regulator-max-microvolt = <920000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529011619.9586-1-harrison.vanderbyl@gmail.com?part=2