Re: [PATCH v4 1/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree Schema Validation Bypass for data-lanes property
--

commit cd3810bac14e15433ba605ad5fc1eeb8345f5c17
Author: Damon Ding <damon.ding@rock-chips.com>

dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

This commit adds support for the data-lanes property to the port@1 endpoint
in the analogix-dp binding. It allows configuration of physical lane mappings
to handle scenarios like PCB lane swaps or mismatched pin definitions. The
patch also updates the rockchip eDP DT node example to demonstrate this usage.

> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> index 62f0521b09245..ecf206871cdde 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml

[ ... ]

>        port@1:
> -        $ref: /schemas/graph.yaml#/properties/port
> -        description:
> -          Port node with one endpoint connected to a dp-connector node.
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: Port node with one endpoint connected to sink device node.
> +        properties:
> +          endpoint:

[Severity: Low]
Will this literal "endpoint" property match nodes in existing device trees?

It looks like multiple existing device trees, such as rk3399-evb.dts and
rk3288-evb.dtsi, define the endpoint with a unit address as "endpoint@0".

Because these nodes do not perfectly match the literal name "endpoint",
wouldn't they bypass this constraint block entirely, meaning any data-lanes
configuration inside them will not be validated against the specified enum
or maxItems limits?

> +            $ref: /schemas/media/video-interfaces.yaml#
> +            unevaluatedProperties: false
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +                items:
> +                  enum: [ 0, 1, 2, 3 ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529040530.741336-1-damon.ding@rock-chips.com?part=1